Skip to content

fix(sidebar): titles with code element run together#1285

Merged
caugner merged 1 commit intomainfrom
fix-sidebar-code-text
Feb 6, 2026
Merged

fix(sidebar): titles with code element run together#1285
caugner merged 1 commit intomainfrom
fix-sidebar-code-text

Conversation

@LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Feb 6, 2026

Fixes #1270

Tested locally with my local proof of concept for #1282 which screenshots the entirety of the expanded html/css/js sidebars as well as select combinations of highlighted elements.

There's a few subpixel differences across all sidebars, but the major changes are:

before after
sidebar-highlighted-code-and-text-firefox-1366x768-dpr-1 sidebar-highlighted-code-and-text-firefox-1366x768-dpr-1
image image

@LeoMcA LeoMcA requested a review from a team as a code owner February 6, 2026 15:05
@LeoMcA LeoMcA requested a review from caugner February 6, 2026 15:05
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

242007b was deployed to: https://fred-pr1285.review.mdn.allizom.net/

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested on review deployment, LGTM.

@caugner caugner merged commit 15be5f8 into main Feb 6, 2026
12 checks passed
@caugner caugner deleted the fix-sidebar-code-text branch February 6, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Titles with <code> element run together in sidebar

2 participants