fix(sidebar): titles with code element run together#1285
Merged
Conversation
Contributor
|
242007b was deployed to: https://fred-pr1285.review.mdn.allizom.net/ |
caugner
approved these changes
Feb 6, 2026
Contributor
caugner
left a comment
There was a problem hiding this comment.
Nice, tested on review deployment, LGTM.
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1270
Tested locally with my local proof of concept for #1282 which screenshots the entirety of the expanded html/css/js sidebars as well as select combinations of highlighted elements.
There's a few subpixel differences across all sidebars, but the major changes are: