fix lint errors for pubsub and storage tests (firebase#471)

Author: thechenky

spec/providers/pubsub.spec.ts

@@ -21,23 +21,23 @@
 // SOFTWARE.
 
 import { expect } from 'chai';
-import * as pubsub from '../../src/providers/pubsub';
-import * as functions from '../../src/index';
 import { Event } from '../../src/index';
+import * as functions from '../../src/index';
+import * as pubsub from '../../src/providers/pubsub';
 
 describe('Pubsub Functions', () => {
   describe('pubsub.Message', () => {
     describe('#json', () => {
       it('should return json decoded from base64', () => {
-        let message = new pubsub.Message({
+        const message = new pubsub.Message({
           data: new Buffer('{"hello":"world"}', 'utf8').toString('base64'),
         });
 
         expect(message.json.hello).to.equal('world');
       });
 
       it('should preserve passed in json', () => {
-        let message = new pubsub.Message({
+        const message = new pubsub.Message({
           data: new Buffer('{"hello":"world"}', 'utf8').toString('base64'),
           json: { goodbye: 'world' },
         });
@@ -48,10 +48,10 @@ describe('Pubsub Functions', () => {
 
     describe('#toJSON', () => {
       it('should be JSON stringify-able', () => {
-        let encoded = new Buffer('{"hello":"world"}', 'utf8').toString(
+        const encoded = new Buffer('{"hello":"world"}', 'utf8').toString(
           'base64'
         );
-        let message = new pubsub.Message({
+        const message = new pubsub.Message({
           data: encoded,
         });
 
@@ -73,7 +73,7 @@ describe('Pubsub Functions', () => {
     });
 
     it('should allow both region and runtime options to be set', () => {
-      let fn = functions
+      const fn = functions
         .region('us-east1')
         .runWith({
           timeoutSeconds: 90,
@@ -144,14 +144,16 @@ describe('Pubsub Functions', () => {
 
     describe('#schedule', () => {
       it('should return a trigger with schedule', () => {
-        let result = pubsub.schedule('every 5 minutes').onRun(context => null);
+        const result = pubsub
+          .schedule('every 5 minutes')
+          .onRun(context => null);
         expect(result.__trigger.schedule).to.deep.equal({
           schedule: 'every 5 minutes',
         });
       });
 
       it('should return a trigger with schedule and timeZone when one is chosen', () => {
-        let result = pubsub
+        const result = pubsub
           .schedule('every 5 minutes')
           .timeZone('America/New_York')
           .onRun(context => null);
@@ -162,51 +164,55 @@ describe('Pubsub Functions', () => {
       });
 
       it('should return a trigger with schedule and retry config when called with retryConfig', () => {
-        let retryConfig = {
+        const retryConfig = {
           retryCount: 3,
           maxRetryDuration: '10 minutes',
           minBackoffDuration: '10 minutes',
           maxBackoffDuration: '10 minutes',
           maxDoublings: 5,
         };
-        let result = pubsub
+        const result = pubsub
           .schedule('every 5 minutes')
           .retryConfig(retryConfig)
           .onRun(() => null);
         expect(result.__trigger.schedule).to.deep.equal({
           schedule: 'every 5 minutes',
-          retryConfig: retryConfig,
+          retryConfig,
         });
         expect(result.__trigger.labels).to.deep.equal({
           'deployment-scheduled': 'true',
         });
       });
 
-      it('should return a trigger with schedule, timeZone and retry config when called with retryConfig and timeout', () => {
-        let retryConfig = {
-          retryCount: 3,
-          maxRetryDuration: '10 minutes',
-          minBackoffDuration: '10 minutes',
-          maxBackoffDuration: '10 minutes',
-          maxDoublings: 5,
-        };
-        let result = pubsub
-          .schedule('every 5 minutes')
-          .timeZone('America/New_York')
-          .retryConfig(retryConfig)
-          .onRun(() => null);
-        expect(result.__trigger.schedule).to.deep.equal({
-          schedule: 'every 5 minutes',
-          retryConfig: retryConfig,
-          timeZone: 'America/New_York',
-        });
-        expect(result.__trigger.labels).to.deep.equal({
-          'deployment-scheduled': 'true',
-        });
-      });
+      it(
+        'should return a trigger with schedule, timeZone and retry config' +
+          'when called with retryConfig and timeout',
+        () => {
+          const retryConfig = {
+            retryCount: 3,
+            maxRetryDuration: '10 minutes',
+            minBackoffDuration: '10 minutes',
+            maxBackoffDuration: '10 minutes',
+            maxDoublings: 5,
+          };
+          const result = pubsub
+            .schedule('every 5 minutes')
+            .timeZone('America/New_York')
+            .retryConfig(retryConfig)
+            .onRun(() => null);
+          expect(result.__trigger.schedule).to.deep.equal({
+            schedule: 'every 5 minutes',
+            retryConfig,
+            timeZone: 'America/New_York',
+          });
+          expect(result.__trigger.labels).to.deep.equal({
+            'deployment-scheduled': 'true',
+          });
+        }
+      );
 
       it('should return an appropriate trigger when called with region and options', () => {
-        let result = functions
+        const result = functions
           .region('us-east1')
           .runWith({
             timeoutSeconds: 90,
@@ -223,7 +229,7 @@ describe('Pubsub Functions', () => {
       });
 
       it('should return an appropriate trigger when called with region, timeZone, and options', () => {
-        let result = functions
+        const result = functions
           .region('us-east1')
           .runWith({
             timeoutSeconds: 90,
@@ -242,14 +248,14 @@ describe('Pubsub Functions', () => {
       });
 
       it('should return an appropriate trigger when called with region, options and retryConfig', () => {
-        let retryConfig = {
+        const retryConfig = {
           retryCount: 3,
           maxRetryDuration: '10 minutes',
           minBackoffDuration: '10 minutes',
           maxBackoffDuration: '10 minutes',
           maxDoublings: 5,
         };
-        let result = functions
+        const result = functions
           .region('us-east1')
           .runWith({
             timeoutSeconds: 90,
@@ -260,7 +266,7 @@ describe('Pubsub Functions', () => {
           .onRun(() => null);
         expect(result.__trigger.schedule).to.deep.equal({
           schedule: 'every 5 minutes',
-          retryConfig: retryConfig,
+          retryConfig,
         });
         expect(result.__trigger.labels).to.deep.equal({
           'deployment-scheduled': 'true',
@@ -271,14 +277,14 @@ describe('Pubsub Functions', () => {
       });
 
       it('should return an appropriate trigger when called with region, options, retryConfig, and timeZone', () => {
-        let retryConfig = {
+        const retryConfig = {
           retryCount: 3,
           maxRetryDuration: '10 minutes',
           minBackoffDuration: '10 minutes',
           maxBackoffDuration: '10 minutes',
           maxDoublings: 5,
         };
-        let result = functions
+        const result = functions
           .region('us-east1')
           .runWith({
             timeoutSeconds: 90,
@@ -291,7 +297,7 @@ describe('Pubsub Functions', () => {
         expect(result.__trigger.schedule).to.deep.equal({
           schedule: 'every 5 minutes',
           timeZone: 'America/New_York',
-          retryConfig: retryConfig,
+          retryConfig,
         });
         expect(result.__trigger.labels).to.deep.equal({
           'deployment-scheduled': 'true',
@@ -363,7 +369,7 @@ describe('Pubsub Functions', () => {
     });
 
     it('should not throw when #run is called', () => {
-      let cf = pubsub.topic('toppy').onPublish(() => null);
+      const cf = pubsub.topic('toppy').onPublish(() => null);
       expect(cf.run).to.not.throw(Error);
     });
   });