package: don't return invalid ref (stash can only take a hash)

mickeyn · mickeyn · commit b3a4a45af87b · 2017-11-18T22:51:22.000Z
diff --git a/lib/MetaCPAN/Query/Package.pm b/lib/MetaCPAN/Query/Package.pm
@@ -28,9 +28,9 @@ sub get_modules {
         }
     );
 
-    my $hits = $res->{hits}{hits};
-    return [] unless @{$hits};
-    return +{ modules => [ map { $_->{_source}{module_name} } @{$hits} ] };
+    return unless $res->{hits}{total};
+    return +{ modules =>
+            [ map { $_->{_source}{module_name} } @{ $res->{hits}{hits} } ] };
 }
 
 __PACKAGE__->meta->make_immutable;

Original file line number	Diff line number	Diff line change
`@@ -28,9 +28,9 @@ sub get_modules {`
`28`	`28`	`}`
`29`	`29`	`);`
`30`	`30`
`31`		`- my $hits = $res->{hits}{hits};`
`32`		`- return [] unless @{$hits};`
`33`		`- return +{ modules => [ map { $_->{_source}{module_name} } @{$hits} ] };`
	`31`	`+ return unless $res->{hits}{total};`
	`32`	`+ return +{ modules =>`
	`33`	`+ [ map { $_->{_source}{module_name} } @{ $res->{hits}{hits} } ] };`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`__PACKAGE__->meta->make_immutable;`