Skip to content

Commit ecb21d2

Browse files
sebastien-rossetmichaelpro1
sebastien-rosset
authored and
michaelpro1
committed
[Java-client] Add maven-compiler-plugin in pom.xml and enable linter checks by default (OpenAPITools#5866)
* Add maven-compiler-plugin plugin in Java pom.xml and enable linter checks by default * Add maven-compiler-plugin plugin in Java pom.xml and enable linter checks by default
1 parent f978a90 commit ecb21d2

File tree

9 files changed

+71
-4
lines changed

9 files changed

+71
-4
lines changed

‎modules/openapi-generator/src/main/resources/Java/JSON.mustache‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public class JSON {
6969
.registerTypeSelector({{classname}}.class, new TypeSelector() {
7070
@Override
7171
public Class getClassForElement(JsonElement readElement) {
72-
Map classByDiscriminatorValue = new HashMap();
72+
Map<String, Class> classByDiscriminatorValue = new HashMap<String, Class>();
7373
{{#mappedModels}}
7474
classByDiscriminatorValue.put("{{mappingName}}".toUpperCase(Locale.ROOT), {{modelName}}.class);
7575
{{/mappedModels}}

‎modules/openapi-generator/src/main/resources/Java/libraries/okhttp-gson/pom.mustache‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,19 @@
4040

4141
<build>
4242
<plugins>
43+
<plugin>
44+
<groupId>org.apache.maven.plugins</groupId>
45+
<artifactId>maven-compiler-plugin</artifactId>
46+
<version>3.8.1</version>
47+
<configuration>
48+
<fork>true</fork>
49+
<meminitial>128m</meminitial>
50+
<maxmem>512m</maxmem>
51+
<compilerArgs>
52+
<arg>-Xlint:all</arg>
53+
</compilerArgs>
54+
</configuration>
55+
</plugin>
4356
<plugin>
4457
<groupId>org.apache.maven.plugins</groupId>
4558
<artifactId>maven-enforcer-plugin</artifactId>

‎modules/openapi-generator/src/main/resources/Java/pom.mustache‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,20 @@
4040

4141
<build>
4242
<plugins>
43+
<plugin>
44+
<groupId>org.apache.maven.plugins</groupId>
45+
<artifactId>maven-compiler-plugin</artifactId>
46+
<version>3.8.1</version>
47+
<configuration>
48+
<fork>true</fork>
49+
<meminitial>128m</meminitial>
50+
<maxmem>512m</maxmem>
51+
<compilerArgs>
52+
<arg>-Xlint:all</arg>
53+
</compilerArgs>
54+
</configuration>
55+
</plugin>
56+
4357
<plugin>
4458
<groupId>org.apache.maven.plugins</groupId>
4559
<artifactId>maven-enforcer-plugin</artifactId>

‎samples/client/petstore/java/jersey1/pom.xml‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,20 @@
3333

3434
<build>
3535
<plugins>
36+
<plugin>
37+
<groupId>org.apache.maven.plugins</groupId>
38+
<artifactId>maven-compiler-plugin</artifactId>
39+
<version>3.8.1</version>
40+
<configuration>
41+
<fork>true</fork>
42+
<meminitial>128m</meminitial>
43+
<maxmem>512m</maxmem>
44+
<compilerArgs>
45+
<arg>-Xlint:all</arg>
46+
</compilerArgs>
47+
</configuration>
48+
</plugin>
49+
3650
<plugin>
3751
<groupId>org.apache.maven.plugins</groupId>
3852
<artifactId>maven-enforcer-plugin</artifactId>

‎samples/client/petstore/java/okhttp-gson-parcelableModel/pom.xml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,19 @@
3333

3434
<build>
3535
<plugins>
36+
<plugin>
37+
<groupId>org.apache.maven.plugins</groupId>
38+
<artifactId>maven-compiler-plugin</artifactId>
39+
<version>3.8.1</version>
40+
<configuration>
41+
<fork>true</fork>
42+
<meminitial>128m</meminitial>
43+
<maxmem>512m</maxmem>
44+
<compilerArgs>
45+
<arg>-Xlint:all</arg>
46+
</compilerArgs>
47+
</configuration>
48+
</plugin>
3649
<plugin>
3750
<groupId>org.apache.maven.plugins</groupId>
3851
<artifactId>maven-enforcer-plugin</artifactId>

‎samples/client/petstore/java/okhttp-gson-parcelableModel/src/main/java/org/openapitools/client/JSON.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static GsonBuilder createGson() {
5555
.registerTypeSelector(Animal.class, new TypeSelector() {
5656
@Override
5757
public Class getClassForElement(JsonElement readElement) {
58-
Map classByDiscriminatorValue = new HashMap();
58+
Map<String, Class> classByDiscriminatorValue = new HashMap<String, Class>();
5959
classByDiscriminatorValue.put("Dog".toUpperCase(Locale.ROOT), Dog.class);
6060
classByDiscriminatorValue.put("Cat".toUpperCase(Locale.ROOT), Cat.class);
6161
classByDiscriminatorValue.put("BigCat".toUpperCase(Locale.ROOT), BigCat.class);

‎samples/client/petstore/java/okhttp-gson/pom.xml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,19 @@
3333

3434
<build>
3535
<plugins>
36+
<plugin>
37+
<groupId>org.apache.maven.plugins</groupId>
38+
<artifactId>maven-compiler-plugin</artifactId>
39+
<version>3.8.1</version>
40+
<configuration>
41+
<fork>true</fork>
42+
<meminitial>128m</meminitial>
43+
<maxmem>512m</maxmem>
44+
<compilerArgs>
45+
<arg>-Xlint:all</arg>
46+
</compilerArgs>
47+
</configuration>
48+
</plugin>
3649
<plugin>
3750
<groupId>org.apache.maven.plugins</groupId>
3851
<artifactId>maven-enforcer-plugin</artifactId>

‎samples/client/petstore/java/okhttp-gson/src/main/java/org/openapitools/client/JSON.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static GsonBuilder createGson() {
5555
.registerTypeSelector(Animal.class, new TypeSelector() {
5656
@Override
5757
public Class getClassForElement(JsonElement readElement) {
58-
Map classByDiscriminatorValue = new HashMap();
58+
Map<String, Class> classByDiscriminatorValue = new HashMap<String, Class>();
5959
classByDiscriminatorValue.put("Dog".toUpperCase(Locale.ROOT), Dog.class);
6060
classByDiscriminatorValue.put("Cat".toUpperCase(Locale.ROOT), Cat.class);
6161
classByDiscriminatorValue.put("BigCat".toUpperCase(Locale.ROOT), BigCat.class);

‎samples/client/petstore/java/rest-assured/src/main/java/org/openapitools/client/JSON.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public static GsonBuilder createGson() {
5555
.registerTypeSelector(Animal.class, new TypeSelector() {
5656
@Override
5757
public Class getClassForElement(JsonElement readElement) {
58-
Map classByDiscriminatorValue = new HashMap();
58+
Map<String, Class> classByDiscriminatorValue = new HashMap<String, Class>();
5959
classByDiscriminatorValue.put("Dog".toUpperCase(Locale.ROOT), Dog.class);
6060
classByDiscriminatorValue.put("Cat".toUpperCase(Locale.ROOT), Cat.class);
6161
classByDiscriminatorValue.put("BigCat".toUpperCase(Locale.ROOT), BigCat.class);

0 commit comments

Comments
 (0)