Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microbit-foundation/micropython-microbit-v2-simulator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.12
Choose a base ref
...
head repository: microbit-foundation/micropython-microbit-v2-simulator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.13
Choose a head ref
  • 3 commits
  • 6 files changed
  • 2 contributors

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    162fb87 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Improve support for older Safari versions (except speech) (#109)

    - Update build workflow to use Node 20.x
    - Use webkitAudioContext is AudioContext is not defined
    - Use audioCtx.createBuffer in place of new AudioBuffer
    - Use createBufferSource in place of new AudioBufferSourceNode
    - Fix layout that relied on aspect-ratio, closes #94 
    
    An issue with the sample rate still remains for modspeech.
    
    Changes made to accommodate Safari 13 and 14.
    microbit-robert authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    93065b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Older Safari: Handle speech sample rate errors, reuse audio context (#…

    …111)
    
    - Workaround for #110 where we've observed that the sample rate of 19000 isn't supported. We'll aim to increase the sample rate in a separate PR but this will at least mean the simulator isn't put in a bad state.
    - Reuse the audio context created after the user interaction, as there are limits to how many you can create on Safari 13 (4 in my BrowserStack testing). I think we always intended to do this, but careful review needed as this is a more significant change than I was anticipating. We already had clean up code for the nodes when the board stops. We never cleaned up the context. So I think we were assuming it lived forever. If this doesn't work out then an alternative is to try closing the old one before creating the new one.
    microbit-matt-hillsdon authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4c00805 View commit details
    Browse the repository at this point in the history
Loading