Skip to content

Added diagnostic logging #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremydvoss merged 1 commit into from
Jan 12, 2023
Merged

Added diagnostic logging #212

jeremydvoss merged 1 commit into from
Jan 12, 2023

Conversation

@jeremydvoss
Copy link
Member

@jeremydvoss jeremydvoss commented Nov 23, 2022 •
edited
Loading

Added diagnostic and status loggers. These loggers are only active in App Service environments. The status logger outputs during initialization and rewrites the file each time. It is used only to get the current status of the distro's initialization and check if something went wrong. The diagnostic logger handler's function is twofold.

  1. It's added to the "opentelemetry" logger so as to capture all opentelemetry logs and send them to a file for App Service to pick up.
  2. The AzureDiagnosticLogger class has methods through which distro-level logs can be created.

Node Loggers: https://dev.azure.com/msazure/One/_git/MGMT-AppInsights-NodeJS-IPA?path=/src/Loader.ts

@jeremydvoss jeremydvoss force-pushed the diagnostics branch 3 times, most recently from 8ef190c to 973b229 Compare December 15, 2022 20:08
@jeremydvoss jeremydvoss marked this pull request as ready for review December 15, 2022 22:40
@jeremydvoss jeremydvoss requested review from a team and lzchen as code owners December 15, 2022 22:40
@lzchen
Copy link
Contributor

lzchen commented Jan 5, 2023

@jeremydvoss

Might I suggest splitting up this PR into diagnostic logger and status logger? Seems like that would be easier to review and merge in.

@jeremydvoss
Copy link
Member Author

jeremydvoss commented Jan 6, 2023

As Leighton suggested, I removed status logger from this pr.

@jeremydvoss jeremydvoss changed the title Added diagnostic and status loggers Added diagnostic Jan 12, 2023
@jeremydvoss jeremydvoss changed the title Added diagnostic Added diagnostic logging Jan 12, 2023
@jeremydvoss jeremydvoss merged commit e0f9cd6 into microsoft:main Jan 12, 2023
@jeremydvoss jeremydvoss mentioned this pull request Jan 19, 2023
Closed
@jeremydvoss jeremydvoss mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramthi ramthi ramthi left review comments

@lzchen lzchen lzchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremydvoss @lzchen @ramthi