diff --git a/src/Core/Components/Dialog/FluentDialog.razor b/src/Core/Components/Dialog/FluentDialog.razor index 1ede29b150..4ce4915a54 100644 --- a/src/Core/Components/Dialog/FluentDialog.razor +++ b/src/Core/Components/Dialog/FluentDialog.razor @@ -1,4 +1,4 @@ -@namespace Microsoft.FluentUI.AspNetCore.Components +@namespace Microsoft.FluentUI.AspNetCore.Components @using Microsoft.AspNetCore.Components.Rendering @inherits FluentComponentBase @@ -13,8 +13,7 @@ aria-describedby=@(_parameters.AriaDescribedby ?? AriaDescribedby) aria-labelledby=@(_parameters.AriaLabelledby ?? AriaLabelledby) aria-label=@(_parameters.AriaLabel ?? AriaLabel) - @attributes=@AdditionalAttributes - tabindex="-1"> + @attributes=@AdditionalAttributes> @* Default Header *@ @if (HasDefaultDialogHeader) @@ -39,4 +38,4 @@ } - \ No newline at end of file + diff --git a/src/Core/Components/Dialog/FluentDialog.razor.cs b/src/Core/Components/Dialog/FluentDialog.razor.cs index 5141276fb2..2efbed4b19 100644 --- a/src/Core/Components/Dialog/FluentDialog.razor.cs +++ b/src/Core/Components/Dialog/FluentDialog.razor.cs @@ -165,7 +165,10 @@ protected override async Task OnAfterRenderAsync(bool firstRender) public void Show() { Hidden = false; - Instance.Parameters.Visible = true; + if (Instance is not null) + { + Instance.Parameters.Visible = true; + } RefreshHeaderFooter(); } @@ -175,8 +178,10 @@ public void Show() public void Hide() { Hidden = true; - Instance.Parameters.Visible = false; - //RefreshHeaderFooter(); + if (Instance is not null) + { + Instance.Parameters.Visible = false; + } } /// diff --git a/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_Default.verified.razor.html b/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_Default.verified.razor.html index cbe4ed1093..765981ca96 100644 --- a/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_Default.verified.razor.html +++ b/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_Default.verified.razor.html @@ -1,5 +1,5 @@ - +

Sample title

@@ -16,4 +16,4 @@

Sample title My body

- \ No newline at end of file + diff --git a/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_HeightUnset.verified.razor.html b/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_HeightUnset.verified.razor.html index 2cf0ee4d08..16df0a15e8 100644 --- a/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_HeightUnset.verified.razor.html +++ b/tests/Core/Dialog/FluentDialogServiceTests.FluentDialogService_HeightUnset.verified.razor.html @@ -1,5 +1,5 @@ - +

Sample title

@@ -16,4 +16,4 @@

Sample title My body

- \ No newline at end of file + diff --git a/tests/Core/Dialog/FluentDialogServiceTests.FluentDialog_RenderFragment.verified.razor.html b/tests/Core/Dialog/FluentDialogServiceTests.FluentDialog_RenderFragment.verified.razor.html index 21a7bfc1d2..b0a60adff9 100644 --- a/tests/Core/Dialog/FluentDialogServiceTests.FluentDialog_RenderFragment.verified.razor.html +++ b/tests/Core/Dialog/FluentDialogServiceTests.FluentDialog_RenderFragment.verified.razor.html @@ -1,5 +1,5 @@ - +

Render Fragment Example

@@ -17,4 +17,4 @@

Render Fragment OK Cancel

- \ No newline at end of file + diff --git a/tests/Core/Dialog/FluentDialogTests.FluentDialog_Default.verified.razor.html b/tests/Core/Dialog/FluentDialogTests.FluentDialog_Default.verified.razor.html index 71e857797c..10c16b2b8c 100644 --- a/tests/Core/Dialog/FluentDialogTests.FluentDialog_Default.verified.razor.html +++ b/tests/Core/Dialog/FluentDialogTests.FluentDialog_Default.verified.razor.html @@ -1,2 +1,2 @@ -My dialog content \ No newline at end of file +My dialog content diff --git a/tests/Core/Dialog/FluentDialogTests.FluentDialog_HeaderFooter.verified.razor.html b/tests/Core/Dialog/FluentDialogTests.FluentDialog_HeaderFooter.verified.razor.html index 3a8d576aae..d0dc7d68e3 100644 --- a/tests/Core/Dialog/FluentDialogTests.FluentDialog_HeaderFooter.verified.razor.html +++ b/tests/Core/Dialog/FluentDialogTests.FluentDialog_HeaderFooter.verified.razor.html @@ -1,5 +1,5 @@ - +
Header content @@ -17,4 +17,4 @@ - \ No newline at end of file +