Skip to content

Convert Initializers to OrtValues Phase 2 #25320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 23, 2025
Merged

Convert Initializers to OrtValues Phase 2 #25320

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e4c8244
Adjust InlineIfNode
yuslepukhin Jul 2, 2025
5dc217e
Merge branch 'main' into yusleoukhin/ort_initializers_ii
yuslepukhin Jul 8, 2025
ffb9bbe
Fix a bug in Initializer::ToProtoWithOrtValue
yuslepukhin Jul 8, 2025
e19b938
Address type conversion
yuslepukhin Jul 8, 2025
564c29f
Adjust ToProto() handling of in external data in memory
yuslepukhin Jul 9, 2025
507eb56
Make CoreML accept external initializers
yuslepukhin Jul 9, 2025
5e89498
Fix handling of external data in ToProto*()
yuslepukhin Jul 10, 2025
fdcdc12
Fix compiler error
yuslepukhin Jul 10, 2025
6e29d73
Merge branch 'yuslepukhin/ort_initializers_mac' into yusleoukhin/ort_…
yuslepukhin Jul 10, 2025
a0635b7
Address compile error in Mac code
yuslepukhin Jul 10, 2025
e81b06c
Merge branch 'main' into yusleoukhin/ort_initializers_ii
yuslepukhin Jul 10, 2025
4cbddc9
Adjust in memory references when saving optimized model
yuslepukhin Jul 12, 2025
6ab9839
Merge branch 'main' into yusleoukhin/ort_initializers_ii
yuslepukhin Jul 14, 2025
582f27c
Address ToGraphProto() issues
yuslepukhin Jul 15, 2025
a636579
Fix ToGraphProto() and recreate test databases for test_embedlayer_fu…
yuslepukhin Jul 16, 2025
83c313f
GCC not happy about attr placement
yuslepukhin Jul 16, 2025
2c0f97e
Address build error
yuslepukhin Jul 16, 2025
5c15725
Address compiler error
yuslepukhin Jul 16, 2025
a6b2576
Adjust test data for fastgelu fusion
yuslepukhin Jul 17, 2025
f59c9c6
Address review comments
yuslepukhin Jul 21, 2025
64de315
Add comment and resolve compiler error
yuslepukhin Jul 21, 2025
397fd13
Address review comments
yuslepukhin Jul 22, 2025
93d5614
Address review comments
yuslepukhin Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GCC not happy about attr placement
  • Loading branch information
@yuslepukhin
yuslepukhin committed Jul 16, 2025
commit 83c313f3558ba4a53f9c3ba44f9010f0ca3a471d
2 changes: 1 addition & 1 deletion onnxruntime/core/framework/tensorprotoutils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ inline bool HasRawData(const ONNX_NAMESPACE::TensorProto& ten_proto) {
ten_proto.has_raw_data(); // XXX: Figure out how to do in proto3
}

inline [[nodiscard]] bool HasExternalData(const ONNX_NAMESPACE::TensorProto& ten_proto) {
inline bool HasExternalData(const ONNX_NAMESPACE::TensorProto& ten_proto) {
// Can not be UNDEFINED and can not be STRING but test for STRING is usually performed separately
// to return an error
return ten_proto.data_type() != ONNX_NAMESPACE::TensorProto::UNDEFINED &&
Expand Down
Loading