[MIGraphX EP] Fix CreateExecutionProviderFactory with correct struct and change vendor_id #25625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jywu-msft
added
the
ep:MIGraphX
Contributor
|
@snnn Please help review this PR. |
snnn
approved these changes
Aug 3, 2025
psakhamoori
pushed a commit
to psakhamoori/onnxruntime
that referenced
this pull request
Aug 5, 2025
…and change vendor_id (microsoft#25625) This fixes the CreateIExecutionProvider for MIGraphX EP when calling CreateExecutionProviderFactory, using OrtMIGraphXProviderOptions instead of ProviderOptions. Also changes the vendor_id so that OrderDevices in provider_policy_context.cc will default dml ep when ep_policy is set to GPU. Will update pending more changes to MIGraphX EP. Co-authored-by: ozhang <[email protected]>
nieubank
pushed a commit
that referenced
this pull request
Aug 7, 2025
Cherry-pick MiGraphX EP fixes from upstream for rel-1.23.0 This PR cherry-picks three critical fixes for the MiGraphX Execution Provider: 1. Fix compilation after cherry-picking from win-onnxruntime (#25516) - Adds ORT_UNUSED_PARAMETER(num_devices) to fix unused parameter warning - Corrects struct usage in CreateIExecutionProvider method 2. Fix CreateExecutionProviderFactory with correct struct and change vendor_id (#25625) - Updates vendor_id from 0x1002 to 0x9999 to allow DML EP to be default - Ensures proper device ordering in provider_policy_context.cc 3. Update OrtEpFactory in MiGraphX EP (#25567) - Adds complete OrtEpFactory infrastructure for auto EP selection - Implements all required factory methods with noexcept specifiers - Sets ort_version_supported to ORT_API_VERSION - Enables MiGraphX/AMDGPU EP integration with hardware device detection These fixes ensure MiGraphX EP builds correctly and integrates properly with the ORT execution provider selection framework in the 1.23.0 release. Cherry-picked commits: - 87f1499 - 14ca6df - 131cf40 --------- Co-authored-by: Artur Wojcik <[email protected]> Co-authored-by: Owen Zhang <[email protected]> Co-authored-by: ozhang <[email protected]>
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
…and change vendor_id (microsoft#25625) This fixes the CreateIExecutionProvider for MIGraphX EP when calling CreateExecutionProviderFactory, using OrtMIGraphXProviderOptions instead of ProviderOptions. Also changes the vendor_id so that OrderDevices in provider_policy_context.cc will default dml ep when ep_policy is set to GPU. Will update pending more changes to MIGraphX EP. Co-authored-by: ozhang <[email protected]>
gedoensmax
pushed a commit
to gedoensmax/onnxruntime
that referenced
this pull request
Sep 2, 2025
…and change vendor_id (microsoft#25625) This fixes the CreateIExecutionProvider for MIGraphX EP when calling CreateExecutionProviderFactory, using OrtMIGraphXProviderOptions instead of ProviderOptions. Also changes the vendor_id so that OrderDevices in provider_policy_context.cc will default dml ep when ep_policy is set to GPU. Will update pending more changes to MIGraphX EP. Co-authored-by: ozhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the CreateIExecutionProvider for MIGraphX EP when calling CreateExecutionProviderFactory, using OrtMIGraphXProviderOptions instead of ProviderOptions.
Also changes the vendor_id so that OrderDevices in provider_policy_context.cc will default dml ep when ep_policy is set to GPU. Will update pending more changes to MIGraphX EP.