Add default constructor to Ort::Status. #25860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During CIs and local builds it gets inherited from the base due to using directives, however, that does not work for packaging pipleines. Having default ctor is important for storing Status in containers if needed.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a default constructor to the Ort::Status class to fix packaging pipeline issues. The default constructor was previously inherited from the base class through using Base::Base, but this inheritance approach doesn't work in packaging pipelines.
- Add explicit default constructor declaration to
Ort::Statusclass - Update existing code to use explicit null pointer constructor instead of default constructor
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| onnxruntime_cxx_api.h | Adds explicit default constructor declaration to Status class |
| onnxruntime_cxx_inline.h | Updates Status construction call to use explicit nullptr constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
edgchen1
reviewed
Aug 26, 2025
edgchen1
reviewed
Aug 26, 2025
snnn
approved these changes
Aug 26, 2025
snnn
pushed a commit
that referenced
this pull request
Aug 28, 2025
### Description <!-- Describe your changes. --> Fix packaging pipelines ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> During CIs and local builds Ort::Status() gets inherited from the base due to using directives, however, that does not work for packaging pipelines. Having default ctor is important for storing Status in containers if needed.
snnn
added a commit
that referenced
this pull request
Aug 29, 2025
- **Relax WeightBiasQuantization constraint for larger QDQ node group (#25673)** - **Add cuda graph implementation for NV TRT RTX EP (#25787)** - **python GPU IO Bindings for NVIDIA (#25776)** - **Fixes for DynamicQuantizeMatMul and Attention3D tests (#25814)** - **Fix a long standing bug on file memory mapping on windows. (#25833)** - **Add API for precompiled model compatibility check using just the compat info (#25841)** - **Enable ABSL_FLAGS flag registration for onnxruntime_perf_test for mobile build (#25849)** - **Add default constructor to Ort::Status. (#25860)** - #25871 - #25878 - #25884 - #25886 - #25866
Member
|
The change is added to the release branch |
gedoensmax
pushed a commit
to gedoensmax/onnxruntime
that referenced
this pull request
Sep 2, 2025
### Description <!-- Describe your changes. --> Fix packaging pipelines ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> During CIs and local builds Ort::Status() gets inherited from the base due to using directives, however, that does not work for packaging pipelines. Having default ctor is important for storing Status in containers if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix packaging pipelines
Motivation and Context
During CIs and local builds Ort::Status() gets inherited from the base due to using directives,
however, that does not work for packaging pipelines.
Having default ctor is important for storing Status in containers if needed.