remove un-needed changes

Author: ethanburrelldd

common/changes/@rushstack/operation-graph/eb-concurrency-bug-fix_2025-09-16-19-06.json

@@ -7,7 +7,6 @@
 /// <reference types="node" />
 
 import type { ITerminal } from '@rushstack/terminal';
-import { IWeighted } from '@rushstack/node-core-library';
 
 // @beta
 export type CommandMessageFromHost = ICancelCommandMessage | IExitCommandMessage | IRunCommandMessage | ISyncCommandMessage;
@@ -66,7 +65,6 @@ export interface IOperationExecutionOptions<TOperationMetadata extends {} = {},
 
 // @beta
 export interface IOperationOptions<TMetadata extends {} = {}, TGroupMetadata extends {} = {}> {
-    allowOversubscription?: boolean | undefined;
     group?: OperationGroupRecord<TGroupMetadata> | undefined;
     metadata?: TMetadata | undefined;
     name: string;
@@ -150,11 +148,10 @@ export interface IWatchLoopState {
 }
 
 // @beta
-export class Operation<TMetadata extends {} = {}, TGroupMetadata extends {} = {}> implements IOperationStates, IWeighted {
+export class Operation<TMetadata extends {} = {}, TGroupMetadata extends {} = {}> implements IOperationStates {
     constructor(options: IOperationOptions<TMetadata, TGroupMetadata>);
     // (undocumented)
     addDependency(dependency: Operation<TMetadata, TGroupMetadata>): void;
-    allowOversubscription: boolean;
     readonly consumers: Set<Operation<TMetadata, TGroupMetadata>>;
     criticalPathLength: number | undefined;
     // (undocumented)

common/reviews/api/operation-graph.api.md

@@ -91,15 +91,10 @@ export interface IWeighted {
   weight: number;
 }
 
-interface IWeightedWrapper<TElement> {
-  element: TElement;
-  weight: number;
-}
-
 function toWeightedIterator<TEntry>(
   iterable: Iterable<TEntry> | AsyncIterable<TEntry>,
   useWeights?: boolean
-): AsyncIterable<IWeightedWrapper<TEntry>> {
+): AsyncIterable<{ element: TEntry; weight: number }> {
   const iterator: Iterator<TEntry> | AsyncIterator<TEntry, TEntry> = (
     (iterable as Iterable<TEntry>)[Symbol.iterator] ||
     (iterable as AsyncIterable<TEntry>)[Symbol.asyncIterator]
@@ -111,10 +106,7 @@ function toWeightedIterator<TEntry>(
         // The await is necessary here, but TS will complain - it's a false positive.
         const { value, done } = await iterator.next();
         return {
-          value: {
-            element: value,
-            weight: useWeights ? value?.weight : 1
-          },
+          value: { element: value, weight: useWeights ? value?.weight : 1 },
           done: !!done
         };
       }
@@ -199,7 +191,7 @@ export class Async {
     return result;
   }
 
-  private static async _forEachWeightedAsync<TReturn, TEntry extends IWeightedWrapper<TReturn>>(
+  private static async _forEachWeightedAsync<TReturn, TEntry extends { weight: number; element: TReturn }>(
     iterable: AsyncIterable<TEntry>,
     callback: (entry: TReturn, arrayIndex: number) => Promise<void>,
     options?: IAsyncParallelismOptions | undefined

libraries/node-core-library/src/Async.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved. Licensed under the MIT license.
 // See LICENSE in the project root for license information.
 
-import { InternalError, type IWeighted } from '@rushstack/node-core-library';
+import { InternalError } from '@rushstack/node-core-library';
 import type { ITerminal } from '@rushstack/terminal';
 
 import { Stopwatch } from './Stopwatch';
@@ -41,13 +41,6 @@ export interface IOperationOptions<TMetadata extends {} = {}, TGroupMetadata ext
    */
   weight?: number | undefined;
 
-  /**
-   * Controls whether this operation can start, even if doing so would exceed the total concurrency limit..
-   * If true (default), will start the operation even when it would exceed the limit.
-   * If false, waits until sufficient capacity is available.
-   */
-  allowOversubscription?: boolean | undefined;
-
   /**
    * The metadata for this operation.
    */
@@ -108,7 +101,7 @@ export interface IExecuteOperationContext extends Omit<IOperationRunnerContext,
  * @beta
  */
 export class Operation<TMetadata extends {} = {}, TGroupMetadata extends {} = {}>
-  implements IOperationStates, IWeighted
+  implements IOperationStates
 {
   /**
    * A set of all dependencies which must be executed before this operation is complete.
@@ -181,13 +174,6 @@ export class Operation<TMetadata extends {} = {}, TGroupMetadata extends {} = {}
    */
   public weight: number;
 
-  /**
-   * If true, allows this operation to exceed the concurrency limit when no other operations are running.
-   * If false, enforces strict concurrency limits and waits until sufficient capacity is available.
-   * Defaults to true to maintain backward compatibility with the original behavior.
-   */
-  public allowOversubscription: boolean;
-
   /**
    * The state of this operation the previous time a manager was invoked.
    */
@@ -215,7 +201,6 @@ export class Operation<TMetadata extends {} = {}, TGroupMetadata extends {} = {}
     this.group = options.group;
     this.runner = options.runner;
     this.weight = options.weight ?? 1;
-    this.allowOversubscription = options?.allowOversubscription ?? true;
     this.name = options.name;
     this.metadata = options.metadata || ({} as TMetadata);
 

libraries/operation-graph/src/Operation.ts

@@ -15,7 +15,7 @@ import { Async } from '@rushstack/node-core-library';
 const PLUGIN_NAME: 'WeightedOperationPlugin' = 'WeightedOperationPlugin';
 
 /**
- * Add weights and concurrency behavior to operations based on the operation settings in rush-project.json.
+ * Add weights to operations based on the operation settings in rush-project.json.
  *
  * This also sets the weight of no-op operations to 0.
  */