Add binder benchmark, update parse benchmark, restructure fixtures (#5)

Author: jakebailey

Herebyfile.mjs

@@ -56,7 +56,6 @@ export const generate = task({
 export const test = task({
     name: "test",
     run: async () => {
-        assertTypeScriptCloned();
         await $`go test ${options.race ? ["-race"] : []} ./...`;
         // Run the benchmarks once to ensure they compile and run without errors.
         await $`go test ${options.race ? ["-race"] : []} -run=- -bench=. -benchtime=1x ./...`;

internal/compiler/binder_test.go

@@ -0,0 +1,33 @@
+package compiler
+
+import (
+	"runtime"
+	"testing"
+)
+
+func BenchmarkBind(b *testing.B) {
+	for _, f := range benchFixtures {
+		b.Run(f.Name(), func(b *testing.B) {
+			f.SkipIfNotExist(b)
+
+			fileName := f.Path()
+			sourceText := f.ReadFile(b)
+
+			sourceFiles := make([]*SourceFile, b.N)
+			for i := 0; i < b.N; i++ {
+				sourceFiles[i] = ParseSourceFile(fileName, sourceText, ScriptTargetESNext)
+			}
+
+			compilerOptions := &CompilerOptions{Target: ScriptTargetESNext, ModuleKind: ModuleKindNodeNext}
+
+			// The above parses do a lot of work; ensure GC is settled before we start collecting pefrormance data.
+			runtime.GC()
+			runtime.GC()
+
+			b.ResetTimer()
+			for i := 0; i < b.N; i++ {
+				bindSourceFile(sourceFiles[i], compilerOptions)
+			}
+		})
+	}
+}

internal/compiler/fixtures_test.go

@@ -0,0 +1,16 @@
+package compiler
+
+import (
+	"path/filepath"
+
+	"github.com/microsoft/typescript-go/internal/repo"
+	"github.com/microsoft/typescript-go/internal/testutil/filefixture"
+)
+
+var benchFixtures = []filefixture.Fixture{
+	filefixture.FromString("empty.ts", "empty.ts", ""),
+	filefixture.FromFile("checker.ts", filepath.Join(repo.TypeScriptSubmodulePath, "src/compiler/checker.ts")),
+	filefixture.FromFile("dom.generated.d.ts", filepath.Join(repo.TypeScriptSubmodulePath, "src/lib/dom.generated.d.ts")),
+	filefixture.FromFile("Herebyfile.mjs", filepath.Join(repo.TypeScriptSubmodulePath, "Herebyfile.mjs")),
+	filefixture.FromFile("jsxComplexSignatureHasApplicabilityError.tsx", filepath.Join(repo.TypeScriptSubmodulePath, "tests/cases/compiler/jsxComplexSignatureHasApplicabilityError.tsx")),
+}

internal/compiler/parser_test.go

@@ -1,20 +1,20 @@
 package compiler
 
 import (
-	"fmt"
-	"os"
 	"testing"
 )
 
 func BenchmarkParse(b *testing.B) {
-	fileName := "../../_submodules/TypeScript/src/compiler/checker.ts"
-	bytes, err := os.ReadFile(fileName)
-	if err != nil {
-		fmt.Println(err)
-	}
-	sourceText := string(bytes)
-	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
-		ParseSourceFile(fileName, sourceText, ScriptTargetESNext)
+	for _, f := range benchFixtures {
+		b.Run(f.Name(), func(b *testing.B) {
+			f.SkipIfNotExist(b)
+
+			fileName := f.Path()
+			sourceText := f.ReadFile(b)
+
+			for i := 0; i < b.N; i++ {
+				ParseSourceFile(fileName, sourceText, ScriptTargetESNext)
+			}
+		})
 	}
 }

internal/testutil/filefixture/filefixture.go

@@ -0,0 +1,74 @@
+package filefixture
+
+import (
+	"os"
+	"sync"
+	"testing"
+)
+
+type Fixture interface {
+	Name() string
+	Path() string
+	SkipIfNotExist(t testing.TB)
+	ReadFile(t testing.TB) string
+}
+
+type fromFile struct {
+	name     string
+	path     string
+	contents func() (string, error)
+}
+
+func FromFile(name string, path string) Fixture {
+	return &fromFile{
+		name: name,
+		path: path,
+		// Cache the file contents and errors.
+		contents: sync.OnceValues(func() (string, error) {
+			b, err := os.ReadFile(path)
+			return string(b), err
+		}),
+	}
+}
+
+func (f *fromFile) Name() string { return f.name }
+func (f *fromFile) Path() string { return f.path }
+
+func (f *fromFile) SkipIfNotExist(t testing.TB) {
+	t.Helper()
+
+	if _, err := os.Stat(f.path); err != nil {
+		t.Skipf("Test fixture %q does not exist", f.path)
+	}
+}
+
+func (f *fromFile) ReadFile(t testing.TB) string {
+	t.Helper()
+
+	contents, err := f.contents()
+	if err != nil {
+		t.Fatalf("Failed to read test fixture %q: %v", f.path, err)
+	}
+	return contents
+}
+
+type fromString struct {
+	name     string
+	path     string
+	contents string
+}
+
+func FromString(name string, path string, contents string) Fixture {
+	return &fromString{
+		name:     name,
+		path:     path,
+		contents: contents,
+	}
+}
+
+func (f *fromString) Name() string { return f.name }
+func (f *fromString) Path() string { return f.path }
+
+func (f *fromString) SkipIfNotExist(t testing.TB) {}
+
+func (f *fromString) ReadFile(t testing.TB) string { return f.contents }