Throw exception when trying to set unknown option

Author: tfedor

src/PHPHtmlParser/Exceptions/UnknownOptionException.php

@@ -0,0 +1,13 @@
+<?php declare(strict_types=1);
+namespace PHPHtmlParser\Exceptions;
+
+use Exception;
+
+/**
+ * Class UnknownOptionException
+ *
+ * @package PHPHtmlParser\Exceptions
+ */
+final class UnknownOptionException extends Exception
+{
+}

src/PHPHtmlParser/Options.php

@@ -4,6 +4,8 @@
 
 namespace PHPHtmlParser;
 
+use PHPHtmlParser\Exceptions\UnknownOptionException;
+
 /**
  * Class Options.
  *
@@ -73,10 +75,14 @@ public function __get($key)
      * Sets a new options param to override the current option array.
      *
      * @chainable
+     * @throws UnknownOptionException
      */
     public function setOptions(array $options): Options
     {
         foreach ($options as $key => $option) {
+            if (!isset($this->defaults[$key])) {
+                throw new UnknownOptionException("Option '$option' is not recognized");
+            }
             $this->options[$key] = $option;
         }
 

tests/OptionsTest.php

@@ -2,8 +2,10 @@
 
 declare(strict_types=1);
 
-use PHPHtmlParser\Options;
+use PHPHtmlParser\Dom;
+use PHPHtmlParser\Exceptions\UnknownOptionException;
 use PHPUnit\Framework\TestCase;
+use PHPHtmlParser\Options;
 
 class OptionsTest extends TestCase
 {
@@ -14,26 +16,37 @@ public function testDefaultWhitespaceTextNode()
         $this->assertTrue($options->whitespaceTextNode);
     }
 
+    public function testSettingOption()
+    {
+        $options = new Options;
+        $options->setOptions([
+            'strict' => true,
+        ]);
+
+        $this->assertTrue($options->strict);
+    }
+
     public function testAddingOption()
     {
+        $this->expectException(UnknownOptionException::class);
+
         $options = new Options();
         $options->setOptions([
             'test' => true,
         ]);
-
-        $this->assertTrue($options->test);
     }
 
-    public function testAddingOver()
+    public function testOverwritingOption()
     {
         $options = new Options();
         $options->setOptions([
-            'test' => false,
+            'strict' => false,
         ])->setOptions([
-            'test'               => true,
+            'strict' => true,
             'whitespaceTextNode' => false,
         ]);
 
+        $this->assertTrue($options->get('strict'));
         $this->assertFalse($options->get('whitespaceTextNode'));
     }
 
@@ -42,4 +55,14 @@ public function testGettingNoOption()
         $options = new Options();
         $this->assertEquals(null, $options->get('doesnotexist'));
     }
+
+    public function testUnknownOptionDom() {
+        $dom = new Dom;
+        $dom->setOptions([
+            'unknown_option' => true,
+        ]);
+
+        $this->expectException(UnknownOptionException::class);
+        $dom->load('<div></div>');
+    }
 }