update readme

Author: jensendarren

.gitignore

@@ -1,6 +1,5 @@
 */node_modules
 */dist
-*/src/*/testfiles/*.txt
-*/src/testfiles/*.txt
+*/src/testfiles
 
 TODO.txt

lsp/src/testfiles/.testfilesgohere

@@ -25,18 +25,18 @@ The answers are:
 
 What we do is take each one of the reasons for change listed above and extract into a separate class.
 
-So firstly, let's extract all _logging logic_ into a new class called [StoreLogger](./src/after/StoreLogger.ts) like so. Note that it is domain specific for our Store and not just a generic Logger.
+So firstly, let's extract all _logging logic_ into a new class called [StoreLogger](./src/StoreLogger.ts) like so. Note that it is domain specific for our Store and not just a generic Logger.
 
 What we have done is extracted all the various log calls to a new class. Now this means that if we want to change the logging framework that we use - perhaps because the open source project that built the logger framework becomes depreciated or we find a better solution well now we can change in just this one place.
 
-To use this new logger, we create an instance of it in the [message store class](./src/after/MessageStore.ts) - perviously called FileStore (I'll explain why the name was changed below).
+To use this new logger, we create an instance of it in the [MessageStore](./src/MessageStore.ts) class - perviously called FileStore (I'll explain why the name was changed below).
 
 Now we replace the calls to `console.xyz(...)` to `this.log.xyz(...)` for example:
 
 * Replace: `console.log(“some message: ”, id)`
 * With: `this.log.Saving(id)`
 
-The next thing we need to extract is the logic for caching which can be applied in pretty much the same way. We create a new class [StoreCache](./src/after/StoreCache.ts).
+The next thing we need to extract is the logic for caching which can be applied in pretty much the same way. We create a new class [StoreCache](./src/StoreCache.ts).
 
 Then we need to create an instance of this class in our MessageStore class and call that instead through the implementation.
 
@@ -46,7 +46,7 @@ this.cache = new StoreCache(); // in the MessageStore constructor
 this.cache.AddOrUpdate(id, message); // in the Save method
 ```
 
-Next reason to change that we can address is the way that we apply storage. This will allow us to change where we save files - perhaps to a relational database instead of a filestore - who knows! So what we do is create a separate class called FileSore that is just for reading / writing files to the filestore and use that in our [MessageStore](./src/after/MessageStore.ts) class in the same way as before.
+Next reason to change that we can address is the way that we apply storage. This will allow us to change where we save files - perhaps to a relational database instead of a filestore - who knows! So what we do is create a separate class called FileSore that is just for reading / writing files to the filestore and use that in our [MessageStore](./src/MessageStore.ts) class in the same way as before.
 
 So what are we left with? A better implementation for this class that is now split into other classes each with a Single Responsibility!
 
@@ -60,17 +60,15 @@ Install the dependences. Note this includes `node-ts` which allows to run TypeSc
 npm install
 ```
 
-Now, it should be possible to run the application using the following commands. Note the code in [src/before](./src/before) is _before_ we apply any refactoring for the Single Responsibility Principle and the code in [src/after](./src/after) is _after_ we apply the refactoring for SRP.
+Now, it should be possible to run the application using the following commands. Note this is the _first step_ that we are taking to refactor the original file which is in the root of this project which is the file [FileStore.ts](../FileStore.ts).
 
 ```
-npx ts-node src/before/TestExamples.ts
-npx ts-node src/after/TestExamples.ts
+npx ts-node src/TestExamples.ts
 ```
 
 Alternatively, you can compile the TypeScript files and then run the output JavaScript files form the resuling `dist` folder:
 
 ```
 npm run build
-node dist/before/TestExamples.js
-node dist/after/TestExamples.js
+node dist/TestExamples.js
 ```

ocp/src/testfiles/.testfilesgohere

@@ -2,6 +2,12 @@ import StoreLogger from './StoreLogger'
 import StoreCache from './StoreCache'
 import FileStore from './FileStore'
 import MessageStore from './MessageStore';
+import fs from 'fs';
+import path from 'path'
+
+var dirtest = "./testfiles";
+var dirpath = path.join(__dirname,  dirtest)
+fs.mkdirSync(dirpath)
 
 // Test the StoreLogger class
 console.log("** Test the StoreLogger class **")
@@ -31,8 +37,7 @@ console.log();
   // Test the FileStore class
   console.log("** Test the FileStore class **")
   console.log()
-  var directory = "./testfiles"
-  var filestore = new FileStore(directory, logger)
+  var filestore = new FileStore(dirtest, logger)
   var fileInfo = filestore.getFileInfo(1)
   console.log(fileInfo);
   await filestore.save(1, 'Message File 1')
@@ -48,7 +53,7 @@ console.log();
   // Test the MessageStore class
   console.log("** Test the MessageStore class **")
   console.log()
-  var messagestore = new MessageStore(directory);
+  var messagestore = new MessageStore(dirtest);
   await messagestore.save(99, 'Message 99 saved via MessageStore class')
   var fileMessage99 = messagestore.read(99)
   console.log(fileMessage99)