Skip to content

Commit f76b6b4

Browse files
authored
Remove bok-choy reference (openedx#34216)
* chore: remove bok-choy references
1 parent 4daf452 commit f76b6b4

File tree

6 files changed

+3
-11
lines changed

6 files changed

+3
-11
lines changed

cms/djangoapps/contentstore/xblock_storage_handlers/view_handlers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ def _save_xblock(
498498
publish = "make_public"
499499

500500
# Make public after updating the xblock, in case the caller asked for both an update and a publish.
501-
# Used by Bok Choy tests and by republishing of staff locks.
502501
if publish == "make_public":
503502
modulestore().publish(xblock.location, user.id)
504503

lms/envs/common.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -349,9 +349,8 @@
349349
# .. toggle_implementation: DjangoSetting
350350
# .. toggle_default: False
351351
# .. toggle_description: Set to True to perform acceptance and load test. Auto auth view is responsible for load
352-
# testing and is controlled by this feature flag. Auto-auth causes issues in Bok Choy tests because it resets the
353-
# requesting user. Session verification (of CacheBackedAuthenticationMiddleware) is a security feature, but it
354-
# can be turned off by enabling this feature flag.
352+
# testing and is controlled by this feature flag. Session verification (of CacheBackedAuthenticationMiddleware)
353+
# is a security feature, but it can be turned off by enabling this feature flag.
355354
# .. toggle_use_cases: open_edx
356355
# .. toggle_creation_date: 2013-07-25
357356
# .. toggle_warning: If this has been set to True then the account activation email will be skipped.

openedx/core/djangoapps/cache_toolbox/middleware.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,7 @@ def _verify_session_auth(self, request):
135135
"""
136136
Ensure that the user's session hash hasn't changed.
137137
"""
138-
# Auto-auth causes issues in Bok Choy tests because it resets
139-
# the requesting user. Since session verification is a
138+
# Since session verification is a
140139
# security feature, we can turn it off when auto-auth is
141140
# enabled since auto-auth is highly insecure and only for
142141
# tests.

openedx/tests/xblock_integration/xblock_testcase.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,6 @@ class XBlockEventTestMixin:
8484
8585
Good things to look at as developing the code:
8686
* Gabe's library for parsing events. This is nice.
87-
* Bok choy has a nice Mongo search for events in the cohorts test
88-
case. It is a little slow for the general case.
8987
* This is originally based on a cleanup of the EventTestMixin. We
9088
could work to converge those in some sensible way.
9189
"""

xmodule/assets/library_content/public/js/library_content_edit.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ window.LibraryContentAuthorView = function(runtime, element) {
77
// But it is still inside this xblock's wrapper element, which we can easily find:
88
var $wrapper = $element.parents('*[data-locator="' + usage_id + '"]');
99

10-
// We can't bind to the button itself because in the bok choy test environment,
11-
// it may not yet exist at this point in time... not sure why.
1210
$wrapper.on('click', '.library-update-btn', function(e) {
1311
e.preventDefault();
1412
// Update the XBlock with the latest matching content from the library:

xmodule/library_content_block.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,6 @@ def get_user_id(self):
500500
"""
501501
user_service = self.runtime.service(self, 'user')
502502
if user_service:
503-
# May be None when creating bok choy test fixtures
504503
user_id = user_service.get_current_user().opt_attrs.get('edx-platform.user_id', None)
505504
else:
506505
user_id = None

0 commit comments

Comments
 (0)