fetch sponsors at build time, show ALL non-skeevy sponsors; closes #4271#4272
Conversation
boneskull
added
semver-patch
boneskull
force-pushed
the
boneskull/show-all-sponsors
branch
4 times, most recently
from
f442fda to
d7faae2
Compare
boneskull
changed the title
boneskull
changed the title
|
@outsideris @craigtaub @Munter This is ready |
|
(click thru to deploy preview to see the result) |
- change ordering: sponsors, then backers - blacklist bad actors - rename `default.html` to `default.liquid`, because it's a Liquid template. - fiddles with the CSS a bit - do not attempt to display a link if there is no website
boneskull
force-pushed
the
boneskull/show-all-sponsors
branch
from
d7faae2 to
76f2142
Compare
|
The experience the first time is pretty jarring. When I don't have the images in cache, opencollective is quite slow at responding, so I just get a bunch of empty white space while they are loading. I think we should create a better fallback experience where the images at least have a background color, so I can see that something is supposed to be there. The backer images are easy, because they already have hard coded dimensions of 32x32. lets just put a grey background on there. The sponsors are more difficult, since we don't have the image dimensions as far as I can tell. Can we get those from the opencollective api? I've had a hard time finding their graphql api documentation, or a playground to explore it myself |
|
Found the graphql api (postwoman is awesome), and I can see that we won't be able to get the dimensions that way. I think we should merge the two additions I propose and then I'll see if I can do another optimization pass now that we can post-process data at build time. We could potentially load the images and read their dimensions, so the layout doesn't jump |
|
I opened #4295 against this branch, which should contain a lot of further improvements |
…ing animation that doesn't wait for all images. Progressive enhanced
boneskull
force-pushed
the
boneskull/show-all-sponsors
branch
from
cb74950 to
10bb5d4
Compare
|
@Munter are you intending to add any more to this? |
|
@boneskull let's get this in as-is. I have another idea I'm tinkering on to improve performance, but it shouldn't hold up this pr |
|
Once this is merged I will release 7.2.0. |
|
Sounds like we're all calling go on this. I'll merge |
(#4272) * Show all sponsors on site - change ordering: sponsors, then backers - blacklist bad actors - rename `default.html` to `default.liquid`, because it's a Liquid template. - fiddles with the CSS a bit - do not attempt to display a link if there is no website * use smaller imgs for backers * Fetch all open collective sponsor images to save their dimensions * Reworked avatars. LEss reflows due to image dimensions. Smoother loading animation that doesn't wait for all images. Progressive enhanced * Add standardised lazy loading to all images * Set height on badges to avoid page reflows * Add node version specification in .nvmrc to get netlify up to date * Move avatars javascript to external file for better development experience Co-authored-by: Peter Müller <munter@fumle.dk>
…chajs#4271 (mochajs#4272) * Show all sponsors on site - change ordering: sponsors, then backers - blacklist bad actors - rename `default.html` to `default.liquid`, because it's a Liquid template. - fiddles with the CSS a bit - do not attempt to display a link if there is no website * use smaller imgs for backers * Fetch all open collective sponsor images to save their dimensions * Reworked avatars. LEss reflows due to image dimensions. Smoother loading animation that doesn't wait for all images. Progressive enhanced * Add standardised lazy loading to all images * Set height on badges to avoid page reflows * Add node version specification in .nvmrc to get netlify up to date * Move avatars javascript to external file for better development experience Co-authored-by: Peter Müller <munter@fumle.dk>
4 participants
This is WIP while we sort out the data issues mentioned in #4271.The data issues have been addressed.
It appears we want to blacklist some sites from appearing on mochajs.org, because they are skeevy. See mochajs/admin#10
This PR:
mochajsappears on this list, because we somehow donated to ourself) whose links & logos will not appear on our sitedefault.html) todefault.liquidbecause it's a HTML-based liquid template, which should help with syntax highlighting. does not affect build.faded-images)