Refactoring: Consuming log-symbols alternate to code for win32 in reporters/base.

[MoonSupport]

Description of the Change

I used the log-symbols instead of the code for win32.

Alternate Designs

No alternate designs

Benefits

Mocha already uses log-symbols, so we can remove duplicated code and maintain consistency.

Possible Drawbacks

I also deleted the dot case, But I don't know if the size difference between dot for win32(.) and dot for the others(․) is a problem.

So I think this might be a problem.

Applicable issues

• Enter any applicable Issues here.
  [WSL] Test report corruption #4353

The above issue is not directly related to the PR.

But I think you may want to use alphabets rather than log-symbols to resolve the issue.

like this

success : v or o
fail : x

Please leave a good comment or question at any time :)

• Is this a breaking change (major release)? no
• Is it an enhancement (minor release)? maybe, yes
• Is it a bug fix, or does it not impact production code (patch release)? no

[jsf-clabot]

All committers have signed the CLA.

[boneskull]

Thanks. this looks good to me, but I think we need to consider it a breaking change, so it should wait for v9.0.0.

Can you please sign the CLA?

[MoonSupport]

Ok, I did it :)

[outsideris]

I've re-run AppVeyor and it passed.

[juergba]

@MoonSupport could you rebase to master, please? Thanks.
If all tests have passed, I will merge this PR.

[MoonSupport]

@juergba Done :)

[coveralls]

Coverage increased (+0.08%) to 94.287% when pulling f8dd915 on MoonSupport:master into 641970d on mochajs:master.

[juergba]

@MoonSupport thank you for this PR.

[jimmywarting]

Currently looking into all the dependencies... and one of your dependencies are log-symbol

log-symbols seems like a perfect package if it had just only precomputed the values instead of using chalk as an dependency
the size could have been a lot smaller if it was just written with:

import isUnicodeSupported from 'is-unicode-supported';

const main = {
  info: '\x1B[34mℹ\x1B[39m',
  success: '\x1B[32m✔\x1B[39m',
  warning: '\x1B[33m⚠\x1B[39m',
  error: '\x1B[31m✖\x1B[39m'
};

const fallback = {
  info: '\x1B[34mi\x1B[39m',
  success: '\x1B[32m√\x1B[39m',
  warning: '\x1B[33m‼\x1B[39m',
  error: '\x1B[31m×\x1B[39m'
};

const logSymbols = isUnicodeSupported() ? main : fallback;

export default logSymbols;

Here is one tough: how about inlining this symbols into mocha itself?

[juergba]

@jimmywarting thank you. The size of the code is not the only criteria.

All those codes/numbers (unicode?) isn't the detail level I want to deal with. We need a package which works for different OS/browsers and is well maintained by someone else, not by Mocha.
Time is the main criteria when maintaining a package like Mocha. So inlining those symbols isn't a good idea.