make guarantees about orphaned processes#4465
Merged
Merged
Conversation
- updates workerpool to v6.0.2, which guarantees child processes exit before `Pool#terminate()` resolves - cleanup `test/integration/options/parallel.spec.js`
boneskull
added
type: chore
Member
Author
Member
Author
|
@mochajs/core any review will do, this one is not big. here is what you should look at; scroll down and expand |
outsideris
approved these changes
Oct 9, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool#terminate()resolvestest/integration/options/parallel.spec.js@segrey this will make the guarantee about the worker processes you were asking about in #4403.