Use standard Promise.allSettled instead polyfill#4905
Merged
Conversation
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
added
the
type: chore
Contributor
|
@outsideris I guess this PR makes sense. |
Contributor
Author
|
Oops! Sorry for korea link.
And you can see 12.9.0 release note. |
juergba
approved these changes
Aug 10, 2022
Contributor
juergba
left a comment
juergba
left a comment
There was a problem hiding this comment.
@outsideris thank you for your explanations and this PR.
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
…#4905) Signed-off-by: Outsider <outsideris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
We've introduced @ungap/promise-all-settled in #4476.
And Node.js support Promise.allSettled in Node 12.9.0.
So, we don't need polyfill anymore because we support Node 14+.
Why should this be in core?
We don't need polyfill anymore.
Benefits
dependency is reduced.
Possible Drawbacks
N/A