feat: highlight browser failures#5222
Merged
JoshuaKGoldberg merged 25 commits intoOct 29, 2024
Merged
Conversation
JoshuaKGoldberg
requested changes
Oct 10, 2024
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks great to me, thanks for the overhaul! ✨
Just requesting undoing unrelated changes, to make it easier to review & not take up as much of a diff.
JoshuaKGoldberg
added
the
status: waiting for author
This reverts commit 8552a91.
Member
Author
|
@JoshuaKGoldberg, ready for review :) |
mark-wiemer
commented
Oct 11, 2024
JoshuaKGoldberg
approved these changes
Oct 11, 2024
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looks great to me, thanks for iterating on it & coming up with good ideas! 🙌
Approved - and will leave open for a bit in case anybody from @mochajs/maintenance-crew has time & interest to review.
JoshuaKGoldberg
removed
the
status: waiting for author
Member
Author
|
Thanks @JoshuaKGoldberg, glad I could help. Just curious, is there an ETA for when this might be merged? Would love to see my work deployed (I am a selfish and proud man 😆) |
Member
|
Haha that resonates with me. This is a UI-only change and the other maintainers haven't had time, let's ship! 🚀 |
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
* Format html.js * Remove newlines between JSDoc comments and their symbols * (temp) update template.html to run tests * Color the stat result icon and text based on root suite result * (temp) add template fail and template pass * On first test fail, add fail indicator to stats * Remove extra newline * Format mocha.css with Prettier * Make pass icon color accessible * Cleanup mocha.css var names * Restore template to main * Remove thirteen-year-old comment mochajs@440e38c * Revert "Format html.js" This reverts commit 8552a91. * Revert "Restore template to main" This reverts commit 854ab12. * Color passes and failures count as well * Cleanup stats variables to consts * Fix stats not updating on root suite end * Revert "Remove extra newline" This reverts commit 27a7958. * Restore newlines :( * Restore newlines for real * Reapply "Remove extra newline" This reverts commit c43bffe. * Revert "Format mocha.css with Prettier" This reverts commit 0898ed5. * indent to 5, not 6 chars in mocha.css * Re-add newline in mocha.css * Reapply "Restore template to main" This reverts commit 714ee15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
skipfor root suite will showpassfor simplicity (happy to change)