SERVER-100937 test WCE on dropIndex no-op (#33476)

GitOrigin-RevId: 0fc048c5a4c7eefd7d7ee2d7da3e66515961f895

Author: pierlauro

jstests/libs/write_concern_all_commands.js

@@ -1207,24 +1207,22 @@ const wcCommandsTests = {
         noop: {
             // Passing "*" will drop all indexes except the _id index. The only index on this
             // collection is the _id index, so the command will be a no-op.
-            req: {
-                dropIndexes: collName,
-                index: "*",
-            },
+            req: {dropIndexes: collName, index: "*"},
             setupFunc: (coll, cluster, clusterType, secondariesRunning, optionalArgs) => {
-                assert.commandWorked(coll.insert({a: "a"}));
-                assert.eq(coll.getIndexes().length, 1);
+                // Implicitly create the collection via insert if it doesn't exist
+                assert.commandWorked(coll.insert({b: "b"}));
 
                 stopAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
+
+                optionalArgs.numIndexesBefore = coll.getIndexes().length;
+                // Make a non-acknowledged write so that the no-op will have to fail with WCE
+                assert.commandWorkedIgnoringWriteConcernErrors(
+                    coll.insert({b: "b"}, {writeConcern: {w: 3, wtimeout: 100}}));
             },
             confirmFunc: (res, coll, cluster, clusterType, secondariesRunning, optionalArgs) => {
                 assert.commandWorkedIgnoringWriteConcernErrors(res);
-                let details = res;
-                if ("raw" in details) {
-                    const raw = details.raw;
-                    details = raw[Object.keys(raw)[0]];
-                }
-                assert.eq(coll.getIndexes().length, 1);
+                assert.eq(coll.getIndexes().length, optionalArgs.numIndexesBefore);
+
                 restartAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
             },
         },
@@ -3889,25 +3887,18 @@ const wcTimeseriesViewsCommandsTests = {
             setupFunc: (coll, cluster, clusterType, secondariesRunning, optionalArgs) => {
                 assert.commandWorked(coll.insert({meta: "a", time: timeValue}));
                 assert.commandWorked(coll.getDB().runCommand({dropIndexes: collName, index: "*"}));
-                if (clusterType == "sharded") {
-                    assert.eq(coll.getIndexes().length, 1);
-                } else {
-                    assert.eq(coll.getIndexes().length, 0);
-                }
+                optionalArgs.numIndexesBefore = coll.getIndexes().length;
+
                 stopAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
+
+                // Make a non-acknowledged write so that the no-op will have to fail with WCE
+                assert.commandWorkedIgnoringWriteConcernErrors(coll.insert(
+                    {meta: "a", time: timeValue}, {writeConcern: {w: 'majority', wtimeout: 100}}));
             },
             confirmFunc: (res, coll, cluster, clusterType, secondariesRunning, optionalArgs) => {
                 assert.commandWorkedIgnoringWriteConcernErrors(res);
-                let details = res;
-                if ("raw" in details) {
-                    const raw = details.raw;
-                    details = raw[Object.keys(raw)[0]];
-                }
-                if (clusterType == "sharded") {
-                    assert.eq(coll.getIndexes().length, 1);
-                } else {
-                    assert.eq(coll.getIndexes().length, 0);
-                }
+                assert.eq(coll.getIndexes().length, optionalArgs.numIndexesBefore);
+
                 restartAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
             },
         },
@@ -3935,12 +3926,8 @@ const wcTimeseriesViewsCommandsTests = {
             },
             confirmFunc: (res, coll, cluster, clusterType, secondariesRunning, optionalArgs) => {
                 assert.commandWorkedIgnoringWriteConcernErrors(res);
-                let details = res;
-                if ("raw" in details) {
-                    const raw = details.raw;
-                    details = raw[Object.keys(raw)[0]];
-                }
                 assert.eq(coll.getIndexes().length, optionalArgs.numIndexesBefore);
+
                 restartAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
             },
         },
@@ -5938,13 +5925,11 @@ function shouldSkipTestCase(
     }
 
     if (testCase == "noop") {
-        // TODO SERVER-100937 dropIndexes does not return WCE
-
         // TODO SERVER-100309 adapt/enable setFeatureCompatibilityVersion no-op case once the
         // upgrade procedure will not proactively shard the sessions collection.
         if (clusterType == "sharded" &&
             (shardedDDLCommandsRequiringMajorityCommit.includes(command) ||
-             command == "dropIndexes" || command == "setFeatureCompatibilityVersion")) {
+             command == "setFeatureCompatibilityVersion")) {
             jsTestLog("Skipping " + command + " test for no-op case.");
             return true;
         }