SERVER-102076 Make ServerParameter conditions operation FCV aware (#44101)

GitOrigin-RevId: 8a44d322e3dffdb5803a8f0fab260b9cbe3e118b

Author: pierlauro

.github/CODEOWNERS

@@ -1912,6 +1912,7 @@ WORKSPACE.bazel @10gen/devprod-build @svc-auto-approve-bot
 /src/mongo/db/commands/**/validate.cpp @10gen/server-validate @svc-auto-approve-bot
 /src/mongo/db/commands/**/vote*index_build* @10gen/server-index-builds @svc-auto-approve-bot
 /src/mongo/db/commands/**/rotate_certificates* @10gen/server-security @svc-auto-approve-bot
+/src/mongo/db/commands/**/parameters.cpp @10gen/server-security @svc-auto-approve-bot
 /src/mongo/db/commands/**/profile* @10gen/query-integration-observability @svc-auto-approve-bot
 /src/mongo/db/commands/**/set_profiling_filter_globally_cmd* @10gen/query-integration-observability @svc-auto-approve-bot
 /src/mongo/db/commands/**/top_command.cpp @10gen/query-integration-observability @svc-auto-approve-bot

src/mongo/db/cluster_parameters/cluster_server_parameter_server_status.cpp

@@ -38,11 +38,11 @@ std::set<std::string> getDefaultReportedParameters() {
     return {"pauseMigrationsDuringMultiUpdates"};
 }
 
-bool isParameterSet(ServerParameter* param) {
+bool isParameterSet(OperationContext* opCtx, ServerParameter* param) {
     if (!param) {
         return false;
     }
-    if (!param->isEnabled()) {
+    if (!param->isEnabled(VersionContext::getDecoration(opCtx))) {
         return false;
     }
     if (param->getClusterParameterTime(boost::none) == LogicalTime::kUninitialized) {
@@ -73,7 +73,7 @@ BSONObj ClusterServerParameterServerStatus::_getParametersToReport(OperationCont
     BSONObjBuilder mapBuilder;
     for (const auto& name : _reportedParameters) {
         auto param = _clusterParameters->getIfExists(name);
-        if (!isParameterSet(param)) {
+        if (!isParameterSet(opCtx, param)) {
             continue;
         }
         BSONObjBuilder elementBuilder(mapBuilder.subobjStart(name));

src/mongo/db/cluster_parameters/get_cluster_parameter_invocation.cpp

@@ -68,7 +68,7 @@ GetClusterParameterInvocation::retrieveRequestedParameters(
 
     // For each parameter, generate a BSON representation of it and retrieve its name.
     auto makeBSON = [&](ServerParameter* requestedParameter, bool skipOnError) {
-        if (!requestedParameter->isEnabled()) {
+        if (!requestedParameter->isEnabled(VersionContext::getDecoration(opCtx))) {
             uassert(ErrorCodes::BadValue,
                     str::stream() << "Server parameter: '" << requestedParameter->name()
                                   << "' is disabled",

src/mongo/db/cluster_parameters/set_cluster_parameter_invocation.cpp

@@ -129,7 +129,7 @@ std::pair<BSONObj, BSONObj> SetClusterParameterInvocation::normalizeParameter(
 
     uassert(ErrorCodes::BadValue,
             str::stream() << "Server parameter: '" << sp->name() << "' is disabled",
-            skipValidation || sp->isEnabled());
+            skipValidation || sp->isEnabled(VersionContext::getDecoration(opCtx)));
 
     Timestamp clusterTime =
         clusterParameterTime ? *clusterParameterTime : _dbService.getUpdateClusterTime(opCtx);

src/mongo/db/commands/OWNERS.yml

@@ -60,6 +60,9 @@ filters:
   - "rotate_certificates*":
     approvers:
       - 10gen/server-security
+  - "parameters.cpp":
+    approvers:
+      - 10gen/server-security
   - "profile*":
     approvers:
       - 10gen/query-integration-observability

src/mongo/db/commands/parameters.cpp

@@ -292,7 +292,7 @@ class CmdGet : public BasicCommand {
         for (ServerParameter::Map::const_iterator i = m.begin(); i != m.end(); ++i) {
             // Skip any parameters that should be filtered out according to the command options, as
             // well as any disabled parameters.
-            if (!i->second->isEnabled() ||
+            if (!i->second->isEnabled(VersionContext::getDecoration(opCtx)) ||
                 (requireNameMatch && !cmdObj.hasElement(i->first.c_str())) ||
                 (requireRuntimeSettable && !i->second->allowedToChangeAtRuntime()) ||
                 (requireStartupSettable && !i->second->allowedToChangeAtStartup()) ||
@@ -398,7 +398,7 @@ class CmdSet : public BasicCommand {
             uassert(ErrorCodes::InvalidOptions,
                     str::stream() << "Server parameter: '" << foundParameter->second->name()
                                   << "' is disabled",
-                    foundParameter->second->isEnabled());
+                    foundParameter->second->isEnabled(VersionContext::getDecoration(opCtx)));
 
             // Make sure we are allowed to change this parameter
             uassert(ErrorCodes::IllegalOperation,

src/mongo/db/feature_flag.cpp

@@ -181,7 +181,7 @@ void FCVGatedFeatureFlagBase::appendFlagValueAndMetadata(BSONObjBuilder& flagBui
 
     auto fcvSnapshot = serverGlobalParams.featureCompatibility.acquireFCVSnapshot();
     if (fcvSnapshot.isVersionInitialized()) {
-        // TODO (SERVER-102076): Use VersionContext from opCtx instead of
+        // TODO (SERVER-114119): Use VersionContext from opCtx instead of
         // kVersionContextIgnored_UNSAFE.
         flagBuilder.append("currentlyEnabled",
                            isEnabled(kVersionContextIgnored_UNSAFE, fcvSnapshot));

src/mongo/db/server_options_helpers.cpp

@@ -165,7 +165,7 @@ Status validateBaseOptions(const moe::Environment& params) {
                     str::stream() << "Unknown --setParameter '" << setParam.first << "'"};
         }
 
-        if (!param->isEnabled()) {
+        if (!param->isEnabled(kNoVersionContext)) {
             return {ErrorCodes::BadValue,
                     str::stream() << "--setParameter '" << setParam.first
                                   << "' only available when used with 'enableTestCommands'"};

src/mongo/db/server_parameter.h

@@ -299,8 +299,12 @@ class MONGO_MOD_OPEN ServerParameter {
      */
     bool enable();
 
-    bool isEnabled() const {
-        const auto fcvSnapshot = serverGlobalParams.featureCompatibility.acquireFCVSnapshot();
+    bool isEnabled(const VersionContext& vCtx) const {
+        const auto optFcvSnapshot = vCtx.getOperationFCV(VersionContext::Passkey());
+
+        const auto fcvSnapshot = optFcvSnapshot.has_value()
+            ? *optFcvSnapshot
+            : serverGlobalParams.featureCompatibility.acquireFCVSnapshot();
         return isEnabledOnVersion(
             fcvSnapshot.isVersionInitialized()
                 ? fcvSnapshot.getVersion()

src/mongo/db/version_context.h

@@ -135,6 +135,7 @@ class VersionContext {
         friend class VersionContextTest;
         friend class FCVGatedFeatureFlagBase;
         friend class ShardingDDLCoordinator;
+        friend class ServerParameter;
         Passkey() = default;
         ~Passkey() = default;
     };