Not proper events order in case of handshake failure, close AsyncHttpClient#841

Author: slandelle

src/main/java/com/ning/http/client/providers/netty/channel/ChannelManager.java

@@ -399,7 +399,6 @@ public SslHandler createSslHandler(String peerHost, int peerPort) throws General
         SSLEngine sslEngine = sslEngineFactory.newSSLEngine(peerHost, peerPort);
         SslHandler sslHandler = handshakeTimeout > 0 ? new SslHandler(sslEngine, getDefaultBufferPool(), false, nettyTimer,
                 handshakeTimeout) : new SslHandler(sslEngine);
-        sslHandler.setIssueHandshake(true);
         sslHandler.setCloseOnSSLException(true);
         return sslHandler;
     }

src/main/java/com/ning/http/client/providers/netty/request/NettyConnectListener.java

@@ -18,6 +18,7 @@
 import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelFuture;
 import org.jboss.netty.channel.ChannelFutureListener;
+import org.jboss.netty.handler.ssl.SslHandler;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -61,10 +62,12 @@ private void abortChannelPreemption(String partition) {
             channelManager.abortChannelPreemption(partition);
     }
 
-    private void writeRequest(Channel channel, String partition) {
+    private void writeRequest(Channel channel) {
 
         LOGGER.debug("Request using non cached Channel '{}':\n{}\n", channel, future.getNettyRequest().getHttpRequest());
 
+        Channels.setAttribute(channel, future);
+
         if (future.isDone()) {
             abortChannelPreemption(partition);
             return;
@@ -79,8 +82,24 @@ private void writeRequest(Channel channel, String partition) {
     }
 
     private void onFutureSuccess(final Channel channel) throws ConnectException {
-        Channels.setAttribute(channel, future);
-        writeRequest(channel, partition);
+        
+        SslHandler sslHandler = channel.getPipeline().get(SslHandler.class);
+
+        if (sslHandler != null) {
+            sslHandler.handshake().addListener(new ChannelFutureListener() {
+                
+                @Override
+                public void operationComplete(ChannelFuture future) throws Exception {
+                    if (future.isSuccess())
+                        writeRequest(channel);
+                    else
+                        onFutureFailure(channel, future.getCause());
+                }
+            });
+        
+        } else {
+            writeRequest(channel);
+        }
     }
 
     private void onFutureFailure(Channel channel, Throwable cause) {