Skip to content

Invocations refactoring #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nerzhulart wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Invocations refactoring #85

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
90a1f51
Special evaluator exception type (EvaluatorExceptionThrownException) …
nerzhulart Aug 13, 2015
b72dfaf
EvaluatorExceptionThrownException handling in ValueReference. This al…
nerzhulart Dec 19, 2016
cac578c
Evaluation exception wrapping in CreateObjectValue.
nerzhulart May 13, 2016
54a8ed0
Separate lock object. Get rid of useful Monitor.Pulse()
nerzhulart Sep 13, 2016
f3e1fee
Async operations rewritten to Tasks
nerzhulart Nov 8, 2016
ad8187f
Proper logging: before the exception body was lost, now it's logged.
nerzhulart Nov 22, 2016
5be3b5b
Invocation is awaited infinitely as it was before.
nerzhulart Jan 17, 2017
1d4a9c4
Restore GetInfo() and detailed logging on invocation
nerzhulart Jan 17, 2017
d8ef7b8
More proper evaluation aborting.
nerzhulart Jan 23, 2017
3226be3
Get rid of OperationData
nerzhulart Jan 23, 2017
e9ee3d0
Move checking for cancelled token into try-catch to guarantee that Up…
nerzhulart Feb 1, 2017
5db72cd
CorDebug Invocations rewritten to .Net Task API (commit moved from …
nerzhulart Mar 16, 2017
0aec667
CorDebug Checking for aborted state in CorMethodCall
nerzhulart Mar 16, 2017
e1f7852
More proper evaluation aborting
nerzhulart Mar 16, 2017
ae0eb0f
Trying to continue all threads if eval Abort() and RudeAbort() failed…
nerzhulart Mar 16, 2017
29b6a90
Handle exceptions in AbortImpl() (Moved from MD repo)
nerzhulart Mar 16, 2017
c594ffc
Restore RemoteFrameObject for AsyncEvaluationTracker
nerzhulart Mar 17, 2017
45b3c96
Remove unused file IAsyncOperation.cs
nerzhulart Mar 17, 2017
3f9b165
Break loop if disposed.
nerzhulart Mar 17, 2017
c6f1148
Line endings fix
nerzhulart Mar 17, 2017
e2cf427
Don't call Abort() if operation is alredy in aborting state
nerzhulart Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Evaluation exception wrapping in CreateObjectValue. 
Ignore eval exceptions occured during ToString() calls in type presentation
  • Loading branch information
@nerzhulart
nerzhulart committed Mar 16, 2017
commit cac578c5f14a818e4e1e9469b90b01e04d314654
4 changes: 4 additions & 0 deletions Mono.Debugging/Mono.Debugging.Evaluation/ObjectValueAdaptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ public ObjectValue CreateObjectValue (EvaluationContext ctx, IObjectValueSource
return CreateObjectValueImpl (ctx, source, path, obj, flags);
} catch (EvaluatorAbortedException ex) {
return ObjectValue.CreateFatalError (path.LastName, ex.Message, flags);
} catch (EvaluatorExceptionThrownException ex) {
return ObjectValue.CreateEvaluationException (ctx, source, path, ex);
} catch (EvaluatorException ex) {
return ObjectValue.CreateFatalError (path.LastName, ex.Message, flags);
} catch (Exception ex) {
Expand Down Expand Up @@ -1111,6 +1113,8 @@ public virtual object TargetObjectToObject (EvaluationContext ctx, object obj)
return new EvaluationResult ("{" + CallToString (ctx, obj) + "}");
} catch (TimeOutException) {
// ToString() timed out, fall back to default behavior.
} catch (EvaluatorExceptionThrownException e) {
// ToString() call thrown exception, fall back to default behavior.
}
}

Expand Down