Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/linker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0cb9250
Choose a base ref
...
head repository: dotnet/linker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ae18468
Choose a head ref
  • 6 commits
  • 38 files changed
  • 4 contributors

Commits on Jul 29, 2021

  1. Warn when accessing DAM annotated method via reflection (#2145)

    * Warn when accessing DAM annotated method via reflection
    
    Any access to DAM annotated method must be validated by the trimmer. Normal calls and such are handled already, but direct reflection access or other indirect accesses can lead to trimmer allowing potential invocation of DAM annotated method without validating the annotations. This change will warn whenever such potential "leak" happens.
    
    This applies to method parameter, method return value and field annotations.
    Uses the same infra as RUC already just adds additional checks.
    
    Tests for the new cases.
    
    * Formatting
    
    * Only warn on virtual methods with annotate return value
    
    Annotated return value is mostly not problematic (the caller only "Reads" from it, which is always safe). The only case where it's problematic is if something would override the method at runtime (ref emit) in which case the trimmer can't validate the new code that it fulfills the return value requirements. But that can only happen if the method is virtual.
    
    * PR feedback
    
    * PR feedback
    
    * Remove test code.
    vitek-karas authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    c1d83c9 View commit details
    Browse the repository at this point in the history
  2. Fix warning origin for DAM on types (#2162)

    * Fix warning origin for DAM on types
    
    * Update tests with link to suppression issue
    
    Messages for these warnings can not be suppressed at the member  level
    due to issues described in #2163.
    
    Also fix expected warnings for properties, revert ResultChecker changes,
    and remove redundant test.
    
    * PR feedback
    
    - Include "Attribute" in attribute type names
    - Add comments about why we want to report warnings
    - Add comment about the interaction with RUC on types
    
    * Add testcase for nested type with default ctor
    
    * PR feedback
    
    - Clean up some test attributes
    - Add test with DAM field on annotated PublicMethods type
    - Add link to issue about duplicate warnings
    
    Also use replace DAMT with DAM in tests.
    
    * Use member-level suppressions in tests
    
    * Unify with behavior for DAM warnings
    
    - Don't warn on non-virtual methods that don't have return annotations
    - Use the helpers introduced in #2145
    
    * PR feedback
    
    Clarify that getter without annotated return value doesn't warn because
    it's non-virtual
    sbomer authored Jul 29, 2021
    Configuration menu
    Copy the full SHA
    aec70d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Share DiagnosticStrings add mechanism to generate a DiagnosticDescrip…

    …tor given a DiagnosticId (#2170)
    
    * Add DiagnosticId enum
    Add GetDiagnosticDescriptor
    
    * Check that the diagnostic id is in the range of the supported linker warnings
    
    * Lint
    
    * Share DiagnosticString
    
    * Noisy whitespace
    
    * Warnings go up to 6000 inclusive
    
    * PR feedback
    
    * Get diagnostic string
    Update test
    
    * Lint
    
    * PR feedback
    mateoatr authored Jul 30, 2021
    Configuration menu
    Copy the full SHA
    acd72ce View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2021

  1. Fix typo in warning message (#2182)

    This warning mentions "field" but is about a method.
    sbomer authored Jul 31, 2021
    Configuration menu
    Copy the full SHA
    facfa57 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Update dependencies from https://github.com/dotnet/runtime build 2021…

    …0801.3 (#2186)
    
    [main] Update dependencies from dotnet/runtime
    dotnet-maestro[bot] authored Aug 2, 2021
    Configuration menu
    Copy the full SHA
    d7fb1ac View commit details
    Browse the repository at this point in the history
  2. [main] Update dependencies from dotnet/arcade (#2166)

    [main] Update dependencies from dotnet/arcade
    
    
     - Merge branch 'main' into darc-main-69858aa8-d9b1-4736-8db6-b43a981b11c8
    dotnet-maestro[bot] authored Aug 2, 2021
    Configuration menu
    Copy the full SHA
    ae18468 View commit details
    Browse the repository at this point in the history
Loading