-
Notifications
You must be signed in to change notification settings - Fork 128
Comparing changes
Open a pull request
base repository: dotnet/linker
base: 0cb9250
head repository: dotnet/linker
compare: ae18468
- 6 commits
- 38 files changed
- 4 contributors
Commits on Jul 29, 2021
-
Warn when accessing DAM annotated method via reflection (#2145)
* Warn when accessing DAM annotated method via reflection Any access to DAM annotated method must be validated by the trimmer. Normal calls and such are handled already, but direct reflection access or other indirect accesses can lead to trimmer allowing potential invocation of DAM annotated method without validating the annotations. This change will warn whenever such potential "leak" happens. This applies to method parameter, method return value and field annotations. Uses the same infra as RUC already just adds additional checks. Tests for the new cases. * Formatting * Only warn on virtual methods with annotate return value Annotated return value is mostly not problematic (the caller only "Reads" from it, which is always safe). The only case where it's problematic is if something would override the method at runtime (ref emit) in which case the trimmer can't validate the new code that it fulfills the return value requirements. But that can only happen if the method is virtual. * PR feedback * PR feedback * Remove test code.
Configuration menu - View commit details
-
Copy full SHA for c1d83c9 - Browse repository at this point
Copy the full SHA c1d83c9View commit details -
Fix warning origin for DAM on types (#2162)
* Fix warning origin for DAM on types * Update tests with link to suppression issue Messages for these warnings can not be suppressed at the member level due to issues described in #2163. Also fix expected warnings for properties, revert ResultChecker changes, and remove redundant test. * PR feedback - Include "Attribute" in attribute type names - Add comments about why we want to report warnings - Add comment about the interaction with RUC on types * Add testcase for nested type with default ctor * PR feedback - Clean up some test attributes - Add test with DAM field on annotated PublicMethods type - Add link to issue about duplicate warnings Also use replace DAMT with DAM in tests. * Use member-level suppressions in tests * Unify with behavior for DAM warnings - Don't warn on non-virtual methods that don't have return annotations - Use the helpers introduced in #2145 * PR feedback Clarify that getter without annotated return value doesn't warn because it's non-virtual
Configuration menu - View commit details
-
Copy full SHA for aec70d0 - Browse repository at this point
Copy the full SHA aec70d0View commit details
Commits on Jul 30, 2021
-
Share DiagnosticStrings add mechanism to generate a DiagnosticDescrip…
…tor given a DiagnosticId (#2170) * Add DiagnosticId enum Add GetDiagnosticDescriptor * Check that the diagnostic id is in the range of the supported linker warnings * Lint * Share DiagnosticString * Noisy whitespace * Warnings go up to 6000 inclusive * PR feedback * Get diagnostic string Update test * Lint * PR feedback
Configuration menu - View commit details
-
Copy full SHA for acd72ce - Browse repository at this point
Copy the full SHA acd72ceView commit details
Commits on Jul 31, 2021
-
Fix typo in warning message (#2182)
This warning mentions "field" but is about a method.
Configuration menu - View commit details
-
Copy full SHA for facfa57 - Browse repository at this point
Copy the full SHA facfa57View commit details
Commits on Aug 2, 2021
-
Update dependencies from https://github.com/dotnet/runtime build 2021…
…0801.3 (#2186) [main] Update dependencies from dotnet/runtime
Configuration menu - View commit details
-
Copy full SHA for d7fb1ac - Browse repository at this point
Copy the full SHA d7fb1acView commit details -
[main] Update dependencies from dotnet/arcade (#2166)
[main] Update dependencies from dotnet/arcade - Merge branch 'main' into darc-main-69858aa8-d9b1-4736-8db6-b43a981b11c8
Configuration menu - View commit details
-
Copy full SHA for ae18468 - Browse repository at this point
Copy the full SHA ae18468View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0cb9250...ae18468