Cleanup

Author: Cem Eliguzel

node/cli/src/command.rs

@@ -136,7 +136,7 @@ impl SubstrateCli for Cli {
 }
 
 impl Cli {
-	fn native_runtime_version(spec: &Box<dyn sc_service::ChainSpec>) -> &'static RuntimeVersion {
+	fn runtime_version(spec: &Box<dyn sc_service::ChainSpec>) -> &'static RuntimeVersion {
 		match spec {
 			#[cfg(feature = "moonriver-native")]
 			spec if spec.is_moonriver() => return &moonbeam_service::moonriver_runtime::VERSION,
@@ -399,7 +399,7 @@ pub fn run() -> Result<()> {
 				params.parachain_id.unwrap_or(1000).into(),
 				&cli.run,
 			)?;
-			let state_version = Cli::native_runtime_version(&chain_spec).state_version();
+			let state_version = Cli::runtime_version(&chain_spec).state_version();
 
 			let output_buf = match chain_spec {
 				#[cfg(feature = "moonriver-native")]

test/suites/dev/test-precompile/test-precompile-proxy-leader-demo3.ts

@@ -18,28 +18,22 @@ describeSuite({
     let leaderContractAddress: `0x${string}`;
 
     beforeAll(async function () {
-      console.log("beforeAll Proxy Leader Demo");
       leaderContractAddress = await setupPoolWithParticipants(context);
-      console.log("beforeAll Proxy Leader Demo 2");
 
       const rawTx = context.writeContract!({
         contractName: "ProxyLeaderDemo",
         contractAddress: leaderContractAddress,
         functionName: "startVoting",
         rawTxOnly: true,
       });
-      console.log("beforeAll Proxy Leader Demo 3");
       const { result } = await context.createBlock(rawTx);
-      console.log("beforeAll Proxy Leader Demo 4");
       expectEVMResult(result!.events, "Succeed");
-      console.log("beforeAll Proxy Leader Demo 5");
     });
 
     it({
       id: "T01",
       title: "should not be able to vote if non-participant",
       test: async function () {
-        console.log("beforeAll Proxy Leader Demo T01 1");
         expect(
           await context.readContract!({
             contractAddress: leaderContractAddress,
@@ -48,7 +42,6 @@ describeSuite({
             args: [ALITH_ADDRESS],
           })
         ).to.be.false;
-        console.log("beforeAll Proxy Leader Demo T01 2");
 
         const rawTx = context.writeContract!({
           contractName: "ProxyLeaderDemo",
@@ -58,19 +51,15 @@ describeSuite({
           rawTxOnly: true,
           gas: 1000000n,
         });
-        console.log("beforeAll Proxy Leader Demo T01 3");
         const { result } = await context.createBlock(rawTx);
-        console.log("beforeAll Proxy Leader Demo T01 4");
         expectEVMResult(result!.events, "Revert");
-        console.log("beforeAll Proxy Leader Demo T01 5");
       },
     });
 
     it({
       id: "T02",
       title: "should not be able to vote for non-participant",
       test: async function () {
-        console.log("beforeAll Proxy Leader Demo T02 1");
         expect(
           await context.readContract!({
             contractAddress: leaderContractAddress,
@@ -79,7 +68,6 @@ describeSuite({
             args: [BALTATHAR_ADDRESS],
           })
         ).to.be.true;
-        console.log("beforeAll Proxy Leader Demo T02 2");
 
         const rawTx = context.writeContract!({
           contractName: "ProxyLeaderDemo",
@@ -90,19 +78,15 @@ describeSuite({
           privateKey: BALTATHAR_PRIVATE_KEY,
           gas: 1000000n,
         });
-        console.log("beforeAll Proxy Leader Demo T02 3");
         const { result } = await context.createBlock(rawTx);
-        console.log("beforeAll Proxy Leader Demo T02 4");
         expectEVMResult(result!.events, "Revert");
-        console.log("beforeAll Proxy Leader Demo T02 5");
       },
     });
 
     it({
       id: "T03",
       title: "should be able to vote for participant when participant",
       test: async function () {
-        console.log("beforeAll Proxy Leader Demo T03 1");
         expect(
           await context.readContract!({
             contractAddress: leaderContractAddress,
@@ -111,7 +95,6 @@ describeSuite({
             args: [BALTATHAR_ADDRESS],
           })
         ).to.be.true;
-        console.log("beforeAll Proxy Leader Demo T03 2");
 
         const rawTx = context.writeContract!({
           contractName: "ProxyLeaderDemo",
@@ -122,12 +105,9 @@ describeSuite({
           privateKey: BALTATHAR_PRIVATE_KEY,
           gas: 1_000_000n,
         });
-        console.log("beforeAll Proxy Leader Demo T03 3");
         const { result } = await context.createBlock(rawTx);
-        console.log("beforeAll Proxy Leader Demo T03 4");
 
         expectEVMResult(result!.events, "Succeed");
-        console.log("beforeAll Proxy Leader Demo T03 5");
         expect(
           await context.readContract!({
             contractAddress: leaderContractAddress,
@@ -136,7 +116,6 @@ describeSuite({
             args: [BALTATHAR_ADDRESS],
           })
         ).to.be.false;
-        console.log("beforeAll Proxy Leader Demo T03 6");
       },
     });
   },

test/suites/dev/test-xcm-v3/test-mock-dmp-queue.ts

@@ -114,7 +114,6 @@ describeSuite({
 
         const signedBlock = await context.polkadotJs().rpc.chain.getBlock();
         const apiAt = await context.polkadotJs().at(signedBlock.block.header.hash);
-        console.log("signedBlock", signedBlock.block.header.hash.toHex());
         const allRecords = await apiAt.query.system.events();
 
         // lets grab at which point the dmp queue was exhausted
@@ -146,7 +145,7 @@ describeSuite({
         expect(pageIndex.beginUsed.toBigInt()).to.eq(0n);
         expect(pageIndex.endUsed.toBigInt()).to.eq(0n);
 
-        // NEW PART
+        // Repeat the test with different parameters
         {
           const xcmMessage = new XcmFragment(config)
             .withdraw_asset()