fix: Always fail lint-typescript/tsc job when typecheck fails (#1253)

* fix: always fail `tsc` job when typecheck fails

* fix: TS errors after pipeline fails again

@mrousavy let me know if this fix is correct

Author: chrispader

.github/workflows/lint-typescript.yml

@@ -45,7 +45,8 @@ jobs:
 
       - name: Run TypeScript (tsc)
         run: |
-          bun typecheck | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-on-error -tee
+          set -o pipefail
+          bun typecheck | reviewdog -name="tsc" -efm="%f(%l,%c): error TS%n: %m" -reporter="github-pr-review" -filter-mode="nofilter" -fail-level=error -tee
         env:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

example/src/logPrototypeChain.ts

@@ -1,10 +1,15 @@
-import type { HybridObject } from 'react-native-nitro-modules'
+import type {
+  HybridObject,
+  type PlatformSpec,
+} from 'react-native-nitro-modules'
 
 function dim(string: string): string {
   return `\x1b[2m${string}\x1b[0m`
 }
 
-export function logPrototypeChain(type: HybridObject): void {
+export function logPrototypeChain<Platforms extends PlatformSpec>(
+  type: HybridObject<Platforms>
+): void {
   console.log(`Prototype chain of ${type.name}:`)
   let object = type
   let indentation = '  '