From e16dc21de623b7bd9d3e862d5f9c5e0abb9bea5a Mon Sep 17 00:00:00 2001 From: Takahiro Matsuda Date: Wed, 22 Apr 2020 12:48:11 +0900 Subject: [PATCH 1/2] [Popper] Fix type definition --- packages/material-ui/src/Popper/Popper.d.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/material-ui/src/Popper/Popper.d.ts b/packages/material-ui/src/Popper/Popper.d.ts index 2ccd0eadda7c7d..005e1a57c38011 100644 --- a/packages/material-ui/src/Popper/Popper.d.ts +++ b/packages/material-ui/src/Popper/Popper.d.ts @@ -17,7 +17,11 @@ export type PopperPlacementType = | 'top-start' | 'top'; -export interface PopperProps extends Omit, 'children'> { +export interface PopperProps + extends Omit< + React.DetailedHTMLProps, HTMLDivElement>, + 'children' + > { /** * A HTML element, [referenceObject](https://popper.js.org/docs/v1/#referenceObject), * or a function that returns either. From baf66f1f3eb44e111bfb686842819e5420b98282 Mon Sep 17 00:00:00 2001 From: Olivier Tassinari Date: Wed, 22 Apr 2020 19:36:46 +0200 Subject: [PATCH 2/2] Update packages/material-ui/src/Popper/Popper.d.ts --- packages/material-ui/src/Popper/Popper.d.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/material-ui/src/Popper/Popper.d.ts b/packages/material-ui/src/Popper/Popper.d.ts index 005e1a57c38011..f2a8412256a821 100644 --- a/packages/material-ui/src/Popper/Popper.d.ts +++ b/packages/material-ui/src/Popper/Popper.d.ts @@ -17,11 +17,8 @@ export type PopperPlacementType = | 'top-start' | 'top'; -export interface PopperProps - extends Omit< - React.DetailedHTMLProps, HTMLDivElement>, - 'children' - > { +export interface PopperProps extends Omit, 'children'> { + ref?: React.Ref; /** * A HTML element, [referenceObject](https://popper.js.org/docs/v1/#referenceObject), * or a function that returns either.