Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: n0-computer/iroh
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: n0-computer/iroh
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: connection-state-try-remote
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 6, 2025

  1. Instead of duplicating the entire connection API, have a type parameter

    on Connection that describes the connection state, and implement the fns
    alpn and remote_id differently depending on what the state is.
    
    The upside is that it should be easier to write code that works with both
    a 0rtt connection and a fully initialized connection without having to
    define a trait to abstract over both variants.
    
    The downside is that it is a bit fancy with the types. But then for the
    non 0rtt case you would never see the fanciness, so maybe it is OK?
    rklaehn committed Nov 6, 2025
    Configuration menu
    Copy the full SHA
    e2ddf98 View commit details
    Browse the repository at this point in the history
  2. clippy

    rklaehn committed Nov 6, 2025
    Configuration menu
    Copy the full SHA
    589b7de View commit details
    Browse the repository at this point in the history
  3. Remove the duplication of the connection API in the Incoming/Outgoing…

    …... structs
    
    Note: this requires using .connection() when you want to do something with the
    connection. You could avoid this with Deref, but it seems this way of using
    Deref is frowned upon in rust.
    rklaehn committed Nov 6, 2025
    Configuration menu
    Copy the full SHA
    6153c9e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2025

  1. Configuration menu
    Copy the full SHA
    081bfe6 View commit details
    Browse the repository at this point in the history
  2. Remove OutgoingZeroRttConnection and IncomingZeroRttConnection

    they are now just type aliases for Connection<Incoming...> and
    Connection<Outgoing...>
    
    With this the usage is idential to before. No more .connection() needed
    for e.g. .open_bi().
    rklaehn committed Nov 7, 2025
    Configuration menu
    Copy the full SHA
    75a975e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ddeffc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2025

  1. - Make the marker types public

    - export them and the trait
    - make the data types doc(hidden)
    rklaehn committed Nov 10, 2025
    Configuration menu
    Copy the full SHA
    f69898e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fad11e6 View commit details
    Browse the repository at this point in the history
  3. Make ConnectionState sealed.

    rklaehn committed Nov 10, 2025
    Configuration menu
    Copy the full SHA
    a6e950c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2025

  1. Configuration menu
    Copy the full SHA
    a1cca0a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2025

  1. Configuration menu
    Copy the full SHA
    62d4703 View commit details
    Browse the repository at this point in the history
Loading