Use uniqid()

michael-grunder · michael-grunder · commit dba618a1e06a · 2018-04-10T12:06:36.000-07:00
diff --git a/tests/RedisTest.php b/tests/RedisTest.php
@@ -5466,13 +5466,7 @@ private function generateSessionId()
         } else if (function_exists('openssl_random_pseudo_bytes')) {
             return bin2hex(openssl_random_pseudo_bytes(8));
         } else {
-            /* Not cryptographically secure, but it doesn't need to be
-             * for the test.  We just want an ID */
-            $encoded = '';
-            for ($c = 0; $c < 8; $c++) {
-                $encoded .= chr(rand(65, 90));
-            }
-            return $encoded;
+            return uniqid();
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -5466,13 +5466,7 @@ private function generateSessionId()`
`5466`	`5466`	`} else if (function_exists('openssl_random_pseudo_bytes')) {`
`5467`	`5467`	`return bin2hex(openssl_random_pseudo_bytes(8));`
`5468`	`5468`	`} else {`
`5469`		`- /* Not cryptographically secure, but it doesn't need to be`
`5470`		`- * for the test. We just want an ID */`
`5471`		`- $encoded = '';`
`5472`		`- for ($c = 0; $c < 8; $c++) {`
`5473`		`- $encoded .= chr(rand(65, 90));`
`5474`		`- }`
`5475`		`- return $encoded;`
	`5469`	`+ return uniqid();`
`5476`	`5470`	`}`
`5477`	`5471`	`}`
`5478`	`5472`