Revert "Add Parameter Filter (dotnet#2314)"

This reverts commit 92aba53.

Author: Nathan Ricci

.gitignore

@@ -55,7 +55,6 @@ bld/
 
 # Visual Studio 2017 auto generated files
 Generated\ Files/
-**/*Properties/launchSettings.json
 
 # scenario intermediate directories
 src/scenarios/*/pub

src/benchmarks/micro/Program.cs

@@ -21,7 +21,6 @@ static int Main(string[] args)
             int? partitionIndex;
             List<string> exclusionFilterValue;
             List<string> categoryExclusionFilterValue;
-            Dictionary<string, string> parameterFilterValue;
             bool getDiffableDisasm;
             bool resumeRun;
 
@@ -32,7 +31,6 @@ static int Main(string[] args)
                 argsList = CommandLineOptions.ParseAndRemoveIntParameter(argsList, "--partition-index", out partitionIndex);
                 argsList = CommandLineOptions.ParseAndRemoveStringsParameter(argsList, "--exclusion-filter", out exclusionFilterValue);
                 argsList = CommandLineOptions.ParseAndRemoveStringsParameter(argsList, "--category-exclusion-filter", out categoryExclusionFilterValue);
-                argsList = CommandLineOptions.ParseAndRemovePairsParameter(argsList, "--parameter-filter", out parameterFilterValue);
                 CommandLineOptions.ParseAndRemoveBooleanParameter(argsList, "--disasm-diff", out getDiffableDisasm);
                 CommandLineOptions.ParseAndRemoveBooleanParameter(argsList, "--resume", out resumeRun);
 
@@ -54,7 +52,6 @@ static int Main(string[] args)
                         partitionIndex: partitionIndex,
                         exclusionFilterValue: exclusionFilterValue,
                         categoryExclusionFilterValue: categoryExclusionFilterValue,
-                        parameterFilterValue: parameterFilterValue,
                         getDiffableDisasm: getDiffableDisasm,
                         resumeRun: resumeRun)
                     .AddValidator(new NoWasmValidator(Categories.NoWASM)))

src/harness/BenchmarkDotNet.Extensions/CommandLineOptions.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Numerics;
 
 namespace BenchmarkDotNet.Extensions
 {
@@ -54,29 +53,6 @@ public static List<string> ParseAndRemoveStringsParameter(List<string> argsList,
             return argsList;
         }
 
-        public static List<string> ParseAndRemovePairsParameter(List<string> argsList, string parameter, out Dictionary<string, string> pairValues)
-        {
-            int parameterIndex = argsList.IndexOf(parameter);
-            pairValues = new Dictionary<string, string>();
-
-            if (parameterIndex + 1 < argsList.Count)
-            {
-                while (parameterIndex + 1 < argsList.Count && !argsList[parameterIndex + 1].StartsWith("-"))
-                {
-                    string[] pair = argsList[parameterIndex + 1].Split(":".ToCharArray(), 2);
-                    pairValues.Add(pair[0], pair[1]);
-                    argsList.RemoveAt(parameterIndex + 1);
-                }
-            }
-            //We only want to remove the --exclusion-filter if it exists
-            if (parameterIndex != -1)
-            {
-                argsList.RemoveAt(parameterIndex);
-            }
-
-            return argsList;
-        }
-
         public static void ParseAndRemoveBooleanParameter(List<string> argsList, string parameter, out bool parameterValue)
         {
             int parameterIndex = argsList.IndexOf(parameter);

src/harness/BenchmarkDotNet.Extensions/ParameterFilter.cs

@@ -27,7 +27,6 @@ public static IConfig Create(
             int? partitionIndex = null,
             List<string> exclusionFilterValue = null,
             List<string> categoryExclusionFilterValue = null,
-            Dictionary<string, string> parameterFilterValue = null,
             Job job = null,
             bool getDiffableDisasm = false,
             bool resumeRun = false)
@@ -61,7 +60,6 @@ public static IConfig Create(
                 .AddFilter(new PartitionFilter(partitionCount, partitionIndex))
                 .AddFilter(new ExclusionFilter(exclusionFilterValue))
                 .AddFilter(new CategoryExclusionFilter(categoryExclusionFilterValue))
-                .AddFilter(new ParameterFilter(parameterFilterValue))
                 .AddExporter(JsonExporter.Full) // make sure we export to Json
                 .AddColumn(StatisticColumn.Median, StatisticColumn.Min, StatisticColumn.Max)
                 .AddValidator(TooManyTestCasesValidator.FailOnError)