Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jquery/jquery
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: netmau5/jquery
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 26, 2012

  1. Changed behavior of event propagation in relation to delegated events. 

    I've never liked how event propagation and event delegation worked
together. If you stop propagation of an event on a direct handler, the
delegated handlers will never get called.

That is unless, of course, the delegated and direct handlers are on the
same element. In practice this never happens because delegated events
typically assume they are being attached as handlers at a DOM hierarchy
level above where their closest possible selector match resides.

I guess my biggest problem is that I think all delegated events for a
specific node should execute the same way directly bound events do.
Event.stopImmediatePropagation should still be honored but
stopPropagation shouldn't prevent any delegated events from occuring.

This approach does take some more CPU juice at execution time as we
have to search up the hierarchy for delegated events and do some extra
matching.
    @netmau5
    netmau5 committed Nov 26, 2012
    Configuration menu
    Copy the full SHA
    58cd442 View commit details
    Browse the repository at this point in the history
Loading