Skip to content

fix: Fixed instrumenting the same module installed in different locations #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2024
Merged

fix: Fixed instrumenting the same module installed in different locations #2104

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9f3039
chore: Refactored module instrumentation tracking to use a tracker class
jsumners-nr Mar 18, 2024
ba0eae9
refactor shim constants
jsumners-nr Apr 2, 2024
f599f14
remove unnecessary ternary
jsumners-nr Apr 3, 2024
1438e53
fix isInstrumented
jsumners-nr Apr 3, 2024
01e54de
add in original replication as a test
jsumners-nr Apr 3, 2024
78e384c
revert unnecessary workflow changes
jsumners-nr Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert unnecessary workflow changes
  • Loading branch information
@jsumners-nr
jsumners-nr committed Apr 3, 2024
commit 78e384c839f376c2ba8b1fc77a78fb573eb0722a
14 changes: 7 additions & 7 deletions .github/workflows/ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci --verbose
run: npm ci
- name: Run Linting
run: npm run lint
- name: Inspect Lockfile
Expand All @@ -58,7 +58,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci --verbose
run: npm ci
- name: Run CI Script Unit Tests
run: npm run unit:scripts

Expand All @@ -79,7 +79,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci --verbose
run: npm ci
- name: Run Unit Tests
run: npm run unit
- name: Archive Unit Test Coverage
Expand All @@ -104,7 +104,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci --verbose
run: npm ci
- name: Run Docker Services
run: npm run services
- name: Run Integration Tests
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci --verbose
run: npm ci
- name: Run Docker Services
run: npm run services
- name: Run Versioned Tests
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:
with:
name: logs-${{ matrix.node-version }}.tgz
path: ./logs-${{ matrix.node-version }}.tgz

# There is no coverage for external as that's tracked in their respective repos
versioned-external:
needs: skip_if_release
Expand All @@ -180,7 +180,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci --verbose
run: npm ci
- name: Run Versioned Tests
run: TEST_CHILD_TIMEOUT=600000 npm run versioned:external
env:
Expand Down