fix: Fixed issue with CJS being imported as ESM #2168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
force-pushed
the
issue-2155-alt
branch
from
7a53d5d to
e3a4227
Compare
bizob2828
requested changes
Apr 26, 2024
Member
bizob2828
left a comment
bizob2828
left a comment
There was a problem hiding this comment.
overall makes sense and looks good. a few comments
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| 'use strict' |
| t.context.agent = agent | ||
|
|
||
| const { default: foo } = await import('./foo.cjs?v=' + crypto.randomBytes(16).toString('hex')) | ||
| t.context.mod = foo |
Member
There was a problem hiding this comment.
should you just import this and then access all 3 different exports and verify it works as expected?
Contributor
Author
There was a problem hiding this comment.
I don't think I understand the question. I have to import it after the "agent" is setup because otherwise the registerHooks will not pick up the module.
node-newrelic/test/lib/agent_helper.js
Lines 180 to 190 in cb21d2c
Member
There was a problem hiding this comment.
oh so i meant importing the file to get at default, foo and just the raw module.exports. Looking at this right now you're just getting default correct?
bizob2828
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2155. This PR supercedes #2158.