chore: Fixed aws-sdk-v3 bedrock tests #2211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
added
dev:tests
mrickard
approved these changes
May 23, 2024
Member
|
Weirdly I cannot repro this issue when running |
Contributor
@bizob2828 I was able to reproduce locally that way just now, after deleting/reinstalling modules. |
Member
I am not. I did the same as well. Not sure what's up with my machine |
bizob2828
approved these changes
May 23, 2024
Member
|
3rd time a charm, didn't do anything different |
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that prior to #2208 we somehow lucked into always having
@smithy/smithy-clientavailable in the BedRock chat completions test suite import paths. But post that PR, the resolution will sometimes make it not directly available to that suite. This PR solves the issue by requiring it from the known good paths for it.