Skip to content

Add dark mode toggle in documentation.#1178

Closed
swastkk wants to merge 2 commits into
aboutcode-org:mainfrom
swastkk:dark-mode-documentation
Closed

Add dark mode toggle in documentation.#1178
swastkk wants to merge 2 commits into
aboutcode-org:mainfrom
swastkk:dark-mode-documentation

Conversation

@swastkk

@swastkk swastkk commented Apr 11, 2023

Copy link
Copy Markdown

Reference- #1177

Signed-off-by - swastik swastkk@gmail.com

@swastkk

swastkk commented Apr 11, 2023

Copy link
Copy Markdown
Author

@TG1999 can merge this PR instead .

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! I think we should also add the same to https://github.com/nexB/skeleton, to have this everywhere.

Comment thread docs/source/conf.py

# user starts in light mode

default_dark_mode = False

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what we want, light stays as default, as that is the case without this plugin.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what we want, light stays as default, as that is the case without this plugin.

Yep ✨

@swastkk

swastkk commented Apr 11, 2023

Copy link
Copy Markdown
Author

Will add this in the skeleton as soon as possible ✨🚀

Signed-off-by: swastik <swastkk@gmail.com>
@TG1999
TG1999 force-pushed the dark-mode-documentation branch from 2e470f8 to d98aac9 Compare April 21, 2023 10:42
@TG1999
TG1999 marked this pull request as draft December 12, 2023 20:21
@TG1999

TG1999 commented Dec 12, 2023

Copy link
Copy Markdown
Contributor

@swastkk I am closing this PR in favour of aboutcode-org/skeleton@5ab9b3a, thanks again for raising this PR

@TG1999 TG1999 closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants