Skip to content

Commit e8bc20c

Browse files
Merge pull request #899 from nextcloud/a11y-app-navigation
Add role=navigation and aria-current
2 parents 94b821f + 7d24237 commit e8bc20c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

js/script.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ $(function(){
3838
return;
3939
}
4040

41-
this.$navigation.find('a[data-navigation=' + this.filter + ']').parent().removeClass('active');
41+
this.$navigation.find('a[data-navigation=' + this.filter + ']').parent().removeClass('active').removeAttr('aria-current');
4242
OCA.Activity.InfinitScrolling.firstKnownId = 0;
4343
OCA.Activity.InfinitScrolling.lastGivenId = 0;
4444

@@ -51,7 +51,7 @@ $(function(){
5151
$('#loading_activities').removeClass('hidden');
5252
OCA.Activity.InfinitScrolling.ignoreScroll = 0;
5353

54-
this.$navigation.find('a[data-navigation=' + filter + ']').parent().addClass('active');
54+
this.$navigation.find('a[data-navigation=' + filter + ']').parent().addClass('active').attr('aria-current', 'page');
5555

5656
OCA.Activity.InfinitScrolling.prefill();
5757
}

templates/stream.app.navigation.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@
2222
*
2323
*/
2424
?>
25-
<div id="app-navigation">
25+
<div id="app-navigation" role="navigation">
2626
<ul>
2727
<?php foreach ($_['navigations'] as $navigation) { ?>
28-
<li<?php if ($_['activeNavigation'] === $navigation['id']): ?> class="active"<?php endif; ?>>
28+
<li<?php if ($_['activeNavigation'] === $navigation['id']): ?> class="active" aria-current="page"<?php endif; ?>>
2929
<a data-navigation="<?php p($navigation['id']) ?>"
3030
href="<?php p($navigation['url']) ?>">
3131
<?php if (!empty($navigation['icon'])) { ?>

0 commit comments

Comments
 (0)