From fde4ba82fcf9ea1bd1ada8639b087b9207a2ff59 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 1 Jul 2025 13:03:57 +0200
Subject: [PATCH 1/8] fix(form): fix crashing hasInitialOutput when 'output' is
 not a string

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 src/components/AssistantFormOutputs.vue | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/components/AssistantFormOutputs.vue b/src/components/AssistantFormOutputs.vue
index ffb7cb81..f01664a4 100644
--- a/src/components/AssistantFormOutputs.vue
+++ b/src/components/AssistantFormOutputs.vue
@@ -88,7 +88,10 @@ export default {
 			return false
 		},
 		hasInitialOutput() {
-			return !!this.outputs.output?.trim()
+			if (typeof this.outputs?.output === 'string') {
+				return !!this.outputs.output?.trim()
+			}
+			return false
 		},
 	},
 }

From e271904f8391dfb21445986c9a9de890fd6f4ca5 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 1 Jul 2025 13:04:49 +0200
Subject: [PATCH 2/8] enh(TaskListItem): nicer display for audio inputs and
 outputs

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 src/components/TaskListItem.vue | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/src/components/TaskListItem.vue b/src/components/TaskListItem.vue
index ea0875db..2763853c 100644
--- a/src/components/TaskListItem.vue
+++ b/src/components/TaskListItem.vue
@@ -16,6 +16,12 @@
 				style="margin-right: 8px;"
 				:title="statusTitle" />
 		</template>
+		<template v-if="onlyHasAudioInput" #name>
+			<div class="item-audio-io">
+				<MicrophoneMessageIcon class="item-mic-icon" />
+				<span>{{ t('assistant', 'Audio input') }}</span>
+			</div>
+		</template>
 		<template #subname>
 			<div v-if="isSuccessful && isText2Image"
 				class="inline-images">
@@ -27,6 +33,10 @@
 					:is-output="true"
 					:border-radius="3" />
 			</div>
+			<div v-else-if="isSuccessful && onlyHasAudioOutput" class="item-audio-io">
+				<MicrophoneMessageIcon />
+				<span>{{ t('assistant', 'Audio output') }}</span>
+			</div>
 			<span v-else>
 				{{ subName }}
 			</span>
@@ -69,6 +79,7 @@ import AlertCircleOutlineIcon from 'vue-material-design-icons/AlertCircleOutline
 import CheckIcon from 'vue-material-design-icons/Check.vue'
 import CloseIcon from 'vue-material-design-icons/Close.vue'
 import TrashCanOutlineIcon from 'vue-material-design-icons/TrashCanOutline.vue'
+import MicrophoneMessageIcon from 'vue-material-design-icons/MicrophoneMessage.vue'
 
 import NcListItem from '@nextcloud/vue/components/NcListItem'
 import NcActionButton from '@nextcloud/vue/components/NcActionButton'
@@ -109,6 +120,7 @@ export default {
 		CheckIcon,
 		AlertCircleOutlineIcon,
 		ReloadIcon,
+		MicrophoneMessageIcon,
 	},
 
 	props: {
@@ -152,6 +164,14 @@ export default {
 		isText2Image() {
 			return this.task.type === 'core:text2image'
 		},
+		onlyHasAudioInput() {
+			return Object.values(this.taskType.inputShape)
+				.every(field => field.type === SHAPE_TYPE_NAMES.Audio)
+		},
+		onlyHasAudioOutput() {
+			return Object.values(this.taskType.outputShape)
+				.every(field => field.type === SHAPE_TYPE_NAMES.Audio)
+		},
 		mainName() {
 			return this.textInputPreview
 		},
@@ -235,4 +255,10 @@ export default {
 		width: 28px;
 	}
 }
+
+.item-audio-io {
+	display: flex;
+	align-items: center;
+	gap: 8px;
+}
 </style>

From 09857d1c6521e162d560d50391ff52e6714a66f2 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 1 Jul 2025 13:05:17 +0200
Subject: [PATCH 3/8] enh(AudioDisplay): emphasize audio outputs

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 src/components/fields/AudioDisplay.vue | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/components/fields/AudioDisplay.vue b/src/components/fields/AudioDisplay.vue
index 5131e3ba..97820957 100644
--- a/src/components/fields/AudioDisplay.vue
+++ b/src/components/fields/AudioDisplay.vue
@@ -4,7 +4,8 @@
 -->
 <template>
 	<audio :src="audioUrl"
-		controls />
+		controls
+		:class="{ shadowed: isOutput }" />
 </template>
 
 <script>
@@ -67,5 +68,8 @@ export default {
 <style scoped lang="scss">
 audio {
 	border-radius: 16px;
+	&.shadowed {
+		border: 2px solid var(--color-primary-element);
+	}
 }
 </style>

From 5a15d27a17a081e2dea19114a2f57a1673c677ac Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 1 Jul 2025 18:21:48 +0200
Subject: [PATCH 4/8] enh(recorder): record audio in wav to increase
 compatibility chances

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 package-lock.json                              | 13 +++++++++++++
 package.json                                   |  1 +
 src/components/fields/AudioRecorderWrapper.vue |  9 +++++++--
 3 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 504ebafe..e3cc10be 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -21,6 +21,7 @@
 				"@nextcloud/router": "^3.0.0",
 				"@nextcloud/vue": "^9.0.0-rc.2",
 				"extendable-media-recorder": "^9.2.11",
+				"extendable-media-recorder-wav-encoder": "^7.0.129",
 				"moment": "^2.30.1",
 				"v-click-outside": "^3.2.0",
 				"vue": "^3.5.16",
@@ -7942,6 +7943,18 @@
 				"tslib": "^2.8.1"
 			}
 		},
+		"node_modules/extendable-media-recorder-wav-encoder": {
+			"version": "7.0.129",
+			"resolved": "https://registry.npmjs.org/extendable-media-recorder-wav-encoder/-/extendable-media-recorder-wav-encoder-7.0.129.tgz",
+			"integrity": "sha512-/wqM2hnzvLy/iUlg/EU3JIF8MJcidy8I77Z7CCm5+CVEClDfcs6bH9PgghuisndwKTaud0Dh48RTD83gkfEjCw==",
+			"license": "MIT",
+			"dependencies": {
+				"@babel/runtime": "^7.27.6",
+				"extendable-media-recorder-wav-encoder-broker": "^7.0.119",
+				"extendable-media-recorder-wav-encoder-worker": "^8.0.116",
+				"tslib": "^2.8.1"
+			}
+		},
 		"node_modules/extendable-media-recorder-wav-encoder-broker": {
 			"version": "7.0.119",
 			"resolved": "https://registry.npmjs.org/extendable-media-recorder-wav-encoder-broker/-/extendable-media-recorder-wav-encoder-broker-7.0.119.tgz",
diff --git a/package.json b/package.json
index d9129b3e..e92b4521 100644
--- a/package.json
+++ b/package.json
@@ -50,6 +50,7 @@
 		"@nextcloud/router": "^3.0.0",
 		"@nextcloud/vue": "^9.0.0-rc.2",
 		"extendable-media-recorder": "^9.2.11",
+		"extendable-media-recorder-wav-encoder": "^7.0.129",
 		"moment": "^2.30.1",
 		"v-click-outside": "^3.2.0",
 		"vue": "^3.5.16",
diff --git a/src/components/fields/AudioRecorderWrapper.vue b/src/components/fields/AudioRecorderWrapper.vue
index f51f13d9..9cf78366 100644
--- a/src/components/fields/AudioRecorderWrapper.vue
+++ b/src/components/fields/AudioRecorderWrapper.vue
@@ -47,7 +47,8 @@ import NcButton from '@nextcloud/vue/components/NcButton'
 
 import { showError } from '@nextcloud/dialogs'
 
-import { MediaRecorder } from 'extendable-media-recorder'
+import { MediaRecorder, register } from 'extendable-media-recorder'
+import { connect } from 'extendable-media-recorder-wav-encoder'
 
 /**
  * Slightly simpler than the talk NewMessageAudioRecorder
@@ -123,8 +124,12 @@ export default {
 
 	methods: {
 		async start() {
+			if (!OCA.Assistant.encoderRegistered) {
+				await register(await connect())
+				OCA.Assistant.encoderRegistered = true
+			}
 			const stream = await navigator.mediaDevices.getUserMedia({ audio: true })
-			this.mediaRecorder = new MediaRecorder(stream)
+			this.mediaRecorder = new MediaRecorder(stream, { mimeType: 'audio/wav' })
 
 			// Add event handler to onstop
 			this.mediaRecorder.onstop = this.generateFile

From 98e6c18941eeb1cdd8fc881e3dae4853392d842c Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 1 Jul 2025 18:22:28 +0200
Subject: [PATCH 5/8] fix(vue3): beforeDestroy is now beforeUnmount

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 src/components/AssistantHeaderMenuEntry.vue    | 2 +-
 src/components/TaskList.vue                    | 2 +-
 src/components/fields/AudioRecorderWrapper.vue | 2 +-
 src/mixins/isMobile.js                         | 2 +-
 src/views/ImageResultCustomPickerElement.vue   | 2 +-
 src/views/TextResultCustomPickerElement.vue    | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/components/AssistantHeaderMenuEntry.vue b/src/components/AssistantHeaderMenuEntry.vue
index e0886956..6f623c68 100644
--- a/src/components/AssistantHeaderMenuEntry.vue
+++ b/src/components/AssistantHeaderMenuEntry.vue
@@ -41,7 +41,7 @@ export default {
 	mounted() {
 	},
 
-	beforeDestroy() {
+	beforeUnmount() {
 	},
 
 	methods: {
diff --git a/src/components/TaskList.vue b/src/components/TaskList.vue
index 5eb62000..78f9f51b 100644
--- a/src/components/TaskList.vue
+++ b/src/components/TaskList.vue
@@ -111,7 +111,7 @@ export default {
 		subscribe('assistant:task:updated', this.updateTask)
 	},
 
-	beforeDestroy() {
+	beforeUnmount() {
 		unsubscribe('assistant:task:updated', this.updateTask)
 	},
 
diff --git a/src/components/fields/AudioRecorderWrapper.vue b/src/components/fields/AudioRecorderWrapper.vue
index 9cf78366..724239de 100644
--- a/src/components/fields/AudioRecorderWrapper.vue
+++ b/src/components/fields/AudioRecorderWrapper.vue
@@ -118,7 +118,7 @@ export default {
 	mounted() {
 	},
 
-	beforeDestroy() {
+	beforeUnmount() {
 		this.killStreams()
 	},
 
diff --git a/src/mixins/isMobile.js b/src/mixins/isMobile.js
index d4062f8c..43e5d8fa 100644
--- a/src/mixins/isMobile.js
+++ b/src/mixins/isMobile.js
@@ -12,7 +12,7 @@ export default {
 	beforeMount() {
 		window.addEventListener('resize', this._onResize)
 	},
-	beforeDestroy() {
+	beforeUnmount() {
 		window.removeEventListener('resize', this._onResize)
 	},
 	methods: {
diff --git a/src/views/ImageResultCustomPickerElement.vue b/src/views/ImageResultCustomPickerElement.vue
index 96fb966c..e003fc43 100644
--- a/src/views/ImageResultCustomPickerElement.vue
+++ b/src/views/ImageResultCustomPickerElement.vue
@@ -78,7 +78,7 @@ export default {
 		})
 	},
 
-	beforeDestroy() {
+	beforeUnmount() {
 	},
 
 	methods: {
diff --git a/src/views/TextResultCustomPickerElement.vue b/src/views/TextResultCustomPickerElement.vue
index b647ec20..26db508f 100644
--- a/src/views/TextResultCustomPickerElement.vue
+++ b/src/views/TextResultCustomPickerElement.vue
@@ -70,7 +70,7 @@ export default {
 		})
 	},
 
-	beforeDestroy() {
+	beforeUnmount() {
 	},
 
 	methods: {

From dd8544ea158968cdc53bc9b8ab5a1989feaedf62 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 1 Jul 2025 20:30:31 +0200
Subject: [PATCH 6/8] enh(recording): convert wav to mp3

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 package-lock.json                             |  7 +++
 package.json                                  |  1 +
 src/audioUtils.js                             | 50 +++++++++++++++++++
 .../fields/AudioRecorderWrapper.vue           | 11 ++--
 src/utils.js                                  |  2 -
 5 files changed, 63 insertions(+), 8 deletions(-)
 create mode 100644 src/audioUtils.js

diff --git a/package-lock.json b/package-lock.json
index e3cc10be..f8dcec5e 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -9,6 +9,7 @@
 			"version": "0.0.1",
 			"license": "AGPL-3.0",
 			"dependencies": {
+				"@breezystack/lamejs": "^1.2.7",
 				"@mdi/js": "^7.4.47",
 				"@mdi/svg": "^7.4.47",
 				"@nextcloud/auth": "^2.0.0",
@@ -1662,6 +1663,12 @@
 				"node": ">=6.9.0"
 			}
 		},
+		"node_modules/@breezystack/lamejs": {
+			"version": "1.2.7",
+			"resolved": "https://registry.npmjs.org/@breezystack/lamejs/-/lamejs-1.2.7.tgz",
+			"integrity": "sha512-6wc7ck65ctA75Hq7FYHTtTvGnYs6msgdxiSUICQ+A01nVOWg6rqouZB8IdyteRlfpYYiFovkf67dIeOgWIUzTA==",
+			"license": "LGPL-3.0"
+		},
 		"node_modules/@buttercup/fetch": {
 			"version": "0.2.1",
 			"resolved": "https://registry.npmjs.org/@buttercup/fetch/-/fetch-0.2.1.tgz",
diff --git a/package.json b/package.json
index e92b4521..a49c0087 100644
--- a/package.json
+++ b/package.json
@@ -38,6 +38,7 @@
 		"npm": "^10.0.0"
 	},
 	"dependencies": {
+		"@breezystack/lamejs": "^1.2.7",
 		"@mdi/js": "^7.4.47",
 		"@mdi/svg": "^7.4.47",
 		"@nextcloud/auth": "^2.0.0",
diff --git a/src/audioUtils.js b/src/audioUtils.js
new file mode 100644
index 00000000..9d68eb00
--- /dev/null
+++ b/src/audioUtils.js
@@ -0,0 +1,50 @@
+/**
+ * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import * as lamejs from '@breezystack/lamejs'
+
+export function convertWavToMp3(wavBlob) {
+	return new Promise((resolve, reject) => {
+		const reader = new FileReader()
+
+		reader.onload = function() {
+			const arrayBuffer = this.result
+
+			// Create a WAV decoder
+			// @ts-expect-error - No idea
+			const wavDecoder = lamejs.WavHeader.readHeader(new DataView(arrayBuffer))
+
+			// Get the WAV audio data as an array of samples
+			// const wavSamples = new Int16Array(arrayBuffer as ArrayBuffer, wavDecoder.dataOffset, wavDecoder.dataLen / 2)
+			const wavSamples = new Int16Array(arrayBuffer, wavDecoder.dataOffset, wavDecoder.dataLen / 2)
+
+			// Create an MP3 encoder
+			const mp3Encoder = new lamejs.Mp3Encoder(wavDecoder.channels, wavDecoder.sampleRate, 128)
+
+			// Encode the WAV samples to MP3
+			const mp3Buffer = mp3Encoder.encodeBuffer(wavSamples)
+
+			// Finalize the MP3 encoding
+			const mp3Data = mp3Encoder.flush()
+
+			// Combine the MP3 header and data into a new ArrayBuffer
+			const mp3BufferWithHeader = new Uint8Array(mp3Buffer.length + mp3Data.length)
+			mp3BufferWithHeader.set(mp3Buffer, 0)
+			mp3BufferWithHeader.set(mp3Data, mp3Buffer.length)
+
+			// Create a Blob from the ArrayBuffer
+			const mp3Blob = new Blob([mp3BufferWithHeader], { type: 'audio/mp3' })
+
+			resolve(mp3Blob)
+		}
+
+		reader.onerror = function(error) {
+			reject(error)
+		}
+
+		// Read the input blob as an ArrayBuffer
+		reader.readAsArrayBuffer(wavBlob)
+	})
+}
diff --git a/src/components/fields/AudioRecorderWrapper.vue b/src/components/fields/AudioRecorderWrapper.vue
index 724239de..6b28bd8a 100644
--- a/src/components/fields/AudioRecorderWrapper.vue
+++ b/src/components/fields/AudioRecorderWrapper.vue
@@ -47,6 +47,7 @@ import NcButton from '@nextcloud/vue/components/NcButton'
 
 import { showError } from '@nextcloud/dialogs'
 
+import { convertWavToMp3 } from '../../audioUtils.js'
 import { MediaRecorder, register } from 'extendable-media-recorder'
 import { connect } from 'extendable-media-recorder-wav-encoder'
 
@@ -87,8 +88,6 @@ export default {
 			mediaRecorder: null,
 			// The chunks array
 			chunks: [],
-			// The final audio file blob
-			blob: null,
 			// Switched to true if the recording is aborted
 			aborted: false,
 			// recordTimer
@@ -176,11 +175,12 @@ export default {
 		/**
 		 * Generate the file
 		 */
-		generateFile() {
+		async generateFile() {
 			this.killStreams()
 			if (!this.aborted) {
-				this.blob = new Blob(this.chunks, { type: 'audio/mp3' })
-				this.$emit('new-recording', this.blob)
+				const wavBlob = new Blob(this.chunks, { type: this.mediaRecorder.mimeType })
+				const mp3Blob = await convertWavToMp3(wavBlob)
+				this.$emit('new-recording', mp3Blob)
 				this.$emit('update:is-recording', false)
 			}
 			this.resetComponentData()
@@ -201,7 +201,6 @@ export default {
 			this.audioStream = null
 			this.mediaRecorder = null
 			this.chunks = []
-			this.blob = null
 			this.aborted = false
 			this.recordTime = {
 				minutes: 0,
diff --git a/src/utils.js b/src/utils.js
index f0ff2d55..1c53673e 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -1,5 +1,3 @@
-'use strict'
-
 /**
  * SPDX-FileCopyrightText: 2023 Nextcloud GmbH and Nextcloud contributors
  * SPDX-License-Identifier: AGPL-3.0-or-later

From 387500374860dfc2fcc9f3d0cfebb5eadbfb65f3 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Wed, 2 Jul 2025 14:09:41 +0200
Subject: [PATCH 7/8] fix(text-list-field): fix item deletion and style

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 src/components/fields/ListOfTextsField.vue | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/src/components/fields/ListOfTextsField.vue b/src/components/fields/ListOfTextsField.vue
index 72203ada..096c0d50 100644
--- a/src/components/fields/ListOfTextsField.vue
+++ b/src/components/fields/ListOfTextsField.vue
@@ -10,14 +10,13 @@
 		<div class="text-list-field--items">
 			<div v-for="(v, i) in arrayValue"
 				:key="fieldKey + '-' + i"
-				class="text-list--item">
+				class="text-list-field--items--item">
 				<TextInput
 					:id="fieldKey + '-input' + '-' + i"
 					class="text-input"
 					:value="v ?? ''"
 					:is-output="isOutput"
-					:label="field.description"
-					:placeholder="field.description"
+					placeholder="…"
 					:title="field.name"
 					@update:value="onItemValueChanged(i, $event)" />
 				<NcButton v-if="!isOutput"
@@ -111,9 +110,10 @@ export default {
 				this.$emit('update:value', [])
 				return
 			}
-			const newValue = this.arrayValue.slice().splice(i - 1, 1)
+			const newValue = this.arrayValue.slice()
+			newValue.splice(i, 1)
 			this.$emit('update:value', newValue)
-			console.debug('delete', i)
+			console.debug('[Assistant] Delete', i, 'newValue', newValue)
 		},
 		onAddItem() {
 			const newValue = [...this.arrayValue, '']
@@ -125,11 +125,23 @@ export default {
 
 <style lang="scss">
 .text-list-field {
+	display: flex;
+	flex-direction: column;
+	gap: 8px;
 
 	&--items {
 		display: flex;
 		flex-direction: column;
 		gap: 12px;
+
+		&--item {
+			display: flex;
+			gap: 4px;
+			align-items: center;
+			.text-input {
+				flex-grow: 1;
+			}
+		}
 	}
 }
 </style>

From fd6004f8772d2f4891cc730788c10fec7642e265 Mon Sep 17 00:00:00 2001
From: Julien Veyssier <julien-nc@posteo.net>
Date: Tue, 8 Jul 2025 10:24:33 +0200
Subject: [PATCH 8/8] remove ts specific comments

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
---
 src/audioUtils.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/audioUtils.js b/src/audioUtils.js
index 9d68eb00..79caff3a 100644
--- a/src/audioUtils.js
+++ b/src/audioUtils.js
@@ -13,11 +13,9 @@ export function convertWavToMp3(wavBlob) {
 			const arrayBuffer = this.result
 
 			// Create a WAV decoder
-			// @ts-expect-error - No idea
 			const wavDecoder = lamejs.WavHeader.readHeader(new DataView(arrayBuffer))
 
 			// Get the WAV audio data as an array of samples
-			// const wavSamples = new Int16Array(arrayBuffer as ArrayBuffer, wavDecoder.dataOffset, wavDecoder.dataLen / 2)
 			const wavSamples = new Int16Array(arrayBuffer, wavDecoder.dataOffset, wavDecoder.dataLen / 2)
 
 			// Create an MP3 encoder