Merge pull request #1931 from nextcloud/backport/1929/stable30

provokateurin · web-flow · commit 1fd6a0c7ea86 · 2025-03-28T22:08:11.000+01:00
[stable30] only sync users on explicit request
diff --git a/lib/Service/SyncService.php b/lib/Service/SyncService.php
@@ -146,7 +146,9 @@ public function sync(int $sync = self::SYNC_ALL): void {
 			$this->syncApps();
 		}
 
-		if ($this->shouldSync(self::SYNC_USERS, $sync)) {
+		// This is useless and too heavy on load
+		// we keep it available when running ./occ circles:sync --users
+		if ($sync === self::SYNC_USERS) {
 			$this->syncNextcloudUsers();
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,9 @@ public function sync(int $sync = self::SYNC_ALL): void {`
`146`	`146`	`$this->syncApps();`
`147`	`147`	`}`
`148`	`148`
`149`		`- if ($this->shouldSync(self::SYNC_USERS, $sync)) {`
	`149`	`+ // This is useless and too heavy on load`
	`150`	`+ // we keep it available when running ./occ circles:sync --users`
	`151`	`+ if ($sync === self::SYNC_USERS) {`
`150`	`152`	`$this->syncNextcloudUsers();`
`151`	`153`	`}`
`152`	`154`