Merge pull request #790 from nextcloud/fix/noid/emulate-visitor-on-join

emulate initiator on CircleJoin

Author: ArtificialOwl

lib/Db/MemberRequest.php

@@ -38,6 +38,7 @@
 use OCA\Circles\Model\Circle;
 use OCA\Circles\Model\FederatedUser;
 use OCA\Circles\Model\Member;
+use OCA\Circles\Model\Probes\CircleProbe;
 use OCA\Circles\Model\Probes\MemberProbe;
 
 /**
@@ -288,16 +289,21 @@ public function getInheritedMembers(string $singleId, bool $getData = false, int
 	/**
 	 * @param string $circleId
 	 * @param string $singleId
+	 * @param CircleProbe|null $probe
 	 *
 	 * @return Member
 	 * @throws MemberNotFoundException
 	 * @throws RequestBuilderException
 	 */
-	public function getMember(string $circleId, string $singleId): Member {
+	public function getMember(string $circleId, string $singleId, ?CircleProbe $probe = null): Member {
 		$qb = $this->getMemberSelectSql();
 		$qb->limitToCircleId($circleId);
 		$qb->limitToSingleId($singleId);
 
+		if (!is_null($probe)) {
+			$qb->setOptions([CoreQueryBuilder::MEMBER], $probe->getAsOptions());
+		}
+
 		return $this->getItemFromRequest($qb);
 	}
 

lib/FederatedItems/CircleLeave.php

@@ -49,6 +49,7 @@
 use OCA\Circles\Model\FederatedUser;
 use OCA\Circles\Model\Helpers\MemberHelper;
 use OCA\Circles\Model\Member;
+use OCA\Circles\Model\Probes\CircleProbe;
 use OCA\Circles\Service\ConfigService;
 use OCA\Circles\Service\EventService;
 use OCA\Circles\Service\MembershipService;
@@ -137,7 +138,13 @@ public function verify(FederatedEvent $event): void {
 		if ($member->getId() === '') {
 			try {
 				// make it works for not-yet-members
-				$member = $this->memberRequest->getMember($circle->getSingleId(), $member->getSingleId());
+				$probe = new CircleProbe();
+				$probe->includeNonVisibleCircles();
+				$member = $this->memberRequest->getMember(
+					$circle->getSingleId(),
+					$member->getSingleId(),
+					$probe
+				);
 			} catch (MemberNotFoundException $e) {
 				throw new MemberNotFoundException(StatusCode::$CIRCLE_LEAVE[120], 120);
 			}
@@ -224,10 +231,10 @@ private function selectNewOwner(Circle $circle): Member {
 			if ($member->getLevel() > $newOwner->getLevel()) {
 				$newOwner = $member;
 			} elseif ($member->getLevel() === $newOwner->getLevel()
-					   && ($member->getJoined() < $newOwner->getJoined()
-						   || ($this->configService->isLocalInstance($member->getInstance())
-							   && !$this->configService->isLocalInstance($newOwner->getInstance()))
-					   )) {
+					  && ($member->getJoined() < $newOwner->getJoined()
+						  || ($this->configService->isLocalInstance($member->getInstance())
+							  && !$this->configService->isLocalInstance($newOwner->getInstance()))
+					  )) {
 				$newOwner = $member;
 			}
 		}

lib/Service/CircleService.php

@@ -378,9 +378,15 @@ public function circleJoin(string $circleId): array {
 		$this->federatedUserService->mustHaveCurrentUser();
 
 		$probe = new CircleProbe();
-		$probe->includeNonVisibleCircles();
+		$probe->includeNonVisibleCircles()
+			  ->emulateVisitor();
+
+		$circle = $this->circleRequest->getCircle(
+			$circleId,
+			$this->federatedUserService->getCurrentUser(),
+			$probe
+		);
 
-		$circle = $this->circleRequest->getCircle($circleId, $this->federatedUserService->getCurrentUser(), $probe);
 		if (!$circle->getInitiator()->hasInvitedBy()) {
 			$this->federatedUserService->setMemberPatron($circle->getInitiator());
 		}
@@ -414,7 +420,15 @@ public function circleJoin(string $circleId): array {
 	public function circleLeave(string $circleId, bool $force = false): array {
 		$this->federatedUserService->mustHaveCurrentUser();
 
-		$circle = $this->circleRequest->getCircle($circleId, $this->federatedUserService->getCurrentUser());
+		$probe = new CircleProbe();
+		$probe->includeNonVisibleCircles()
+			  ->emulateVisitor();
+
+		$circle = $this->circleRequest->getCircle(
+			$circleId,
+			$this->federatedUserService->getCurrentUser(),
+			$probe
+		);
 
 		$event = new FederatedEvent(CircleLeave::class);
 		$event->setCircle($circle);