Merge pull request #2076 from nextcloud/fix/noid/allow-user-with-space-in-federated-teams

ArtificialOwl · web-flow · commit 3f64ba2a8535 · 2025-09-08T13:01:55.000-01:00
Fix federated teams with space-containing userid
diff --git a/lib/Tools/ActivityPub/NCSignature.php b/lib/Tools/ActivityPub/NCSignature.php
@@ -197,7 +197,7 @@ private function setIncomingClearSignature(NCSignedRequest $signedRequest): void
 			throw new SignatureException('missing elements in \'headers\'');
 		}
 
-		$target = strtolower($request->getMethod()) . ' ' . $request->getRequestUri();
+		$target = strtolower($request->getMethod()) . ' ' . urldecode($request->getRequestUri());
 		$estimated = ['(request-target): ' . $target];
 
 		foreach ($headers as $key) {

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ private function setIncomingClearSignature(NCSignedRequest $signedRequest): void`
`197`	`197`	`throw new SignatureException('missing elements in \'headers\'');`
`198`	`198`	`}`
`199`	`199`
`200`		`- $target = strtolower($request->getMethod()) . ' ' . $request->getRequestUri();`
	`200`	`+ $target = strtolower($request->getMethod()) . ' ' . urldecode($request->getRequestUri());`
`201`	`201`	`$estimated = ['(request-target): ' . $target];`
`202`	`202`
`203`	`203`	`foreach ($headers as $key) {`