Skip to content

Commit dd6d695

Browse files
ChristophWurstrullzer
authored andcommitted
Fix tests against latest Nextcloud master
Signed-off-by: Christoph Wurst <[email protected]>
1 parent 9429219 commit dd6d695

File tree

5 files changed

+26
-23
lines changed

5 files changed

+26
-23
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
language: php
22
php:
3-
- 7.1
43
- 7.2
54
- 7.3
5+
- 7.4
66

77
env:
88
global:

tests/unit/AppWhitelistTest.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,25 @@
2828
use OCP\IL10N;
2929
use OCP\IURLGenerator;
3030
use OCP\IUser;
31+
use PHPUnit\Framework\MockObject\MockObject;
3132
use Test\TestCase;
3233

3334
class AppWhitelistTest extends TestCase {
34-
/** @var Config|\PHPUnit_Framework_MockObject_MockObject */
35+
/** @var Config|MockObject */
3536
private $config;
36-
/** @var GuestManager|\PHPUnit_Framework_MockObject_MockObject */
37+
/** @var GuestManager|MockObject */
3738
private $guestManager;
38-
/** @var IL10N|\PHPUnit_Framework_MockObject_MockObject */
39+
/** @var IL10N|MockObject */
3940
private $l10n;
40-
/** @var IAppManager|\PHPUnit_Framework_MockObject_MockObject */
41+
/** @var IAppManager|MockObject */
4142
private $appManager;
42-
/** @var IURLGenerator|\PHPUnit_Framework_MockObject_MockObject */
43+
/** @var IURLGenerator|MockObject */
4344
private $urlGenerator;
4445

4546
/** @var AppWhitelist */
4647
private $appWhitelist;
4748

48-
protected function setUp() {
49+
protected function setUp(): void {
4950
parent::setUp();
5051

5152
$this->config = $this->createMock(Config::class);

tests/unit/GroupBackendTest.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,21 @@
2626
use OCA\Guests\GuestManager;
2727
use OCP\IUser;
2828
use OCP\IUserSession;
29+
use PHPUnit\Framework\MockObject\MockObject;
2930
use Test\TestCase;
3031

3132
class GroupBackendTest extends TestCase {
32-
/** @var GuestManager|\PHPUnit_Framework_MockObject_MockObject */
33+
/** @var GuestManager|MockObject */
3334
private $guestManager;
34-
/** @var Config|\PHPUnit_Framework_MockObject_MockObject */
35+
/** @var Config|MockObject */
3536
private $config;
36-
/** @var IUserSession|\PHPUnit_Framework_MockObject_MockObject */
37+
/** @var IUserSession|MockObject */
3738
private $userSession;
3839

3940
/** @var GroupBackend */
4041
private $backend;
4142

42-
protected function setUp() {
43+
protected function setUp(): void {
4344
parent::setUp();
4445

4546
$this->guestManager = $this->createMock(GuestManager::class);

tests/unit/GuestManagerTest.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,30 +31,31 @@
3131
use OCP\Security\ICrypto;
3232
use OCP\Security\ISecureRandom;
3333
use OCP\Share\IManager;
34+
use PHPUnit\Framework\MockObject\MockObject;
3435
use Test\TestCase;
3536

3637
class GuestManagerTest extends TestCase {
37-
/** @var UserBackend|\PHPUnit_Framework_MockObject_MockObject */
38+
/** @var UserBackend|MockObject */
3839
private $userBackend;
39-
/** @var IUserSession|\PHPUnit_Framework_MockObject_MockObject */
40+
/** @var IUserSession|MockObject */
4041
private $userSession;
41-
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */
42+
/** @var IConfig|MockObject */
4243
private $config;
43-
/** @var ISecureRandom|\PHPUnit_Framework_MockObject_MockObject */
44+
/** @var ISecureRandom|MockObject */
4445
private $random;
45-
/** @var ICrypto|\PHPUnit_Framework_MockObject_MockObject */
46+
/** @var ICrypto|MockObject */
4647
private $crypto;
47-
/** @var IManager|\PHPUnit_Framework_MockObject_MockObject */
48+
/** @var IManager|MockObject */
4849
private $shareManager;
49-
/** @var IDBConnection|\PHPUnit_Framework_MockObject_MockObject */
50+
/** @var IDBConnection|MockObject */
5051
private $conneciton;
51-
/** @var IEventDispatcher|\PHPUnit_Framework_MockObject_MockObject */
52+
/** @var IEventDispatcher|MockObject */
5253
private $eventDispatcher;
5354

5455
/** @var GuestManager */
5556
private $guestManager;
5657

57-
protected function setUp() {
58+
protected function setUp(): void {
5859
parent::setUp();
5960

6061
$this->userBackend = $this->createMock(UserBackend::class);

tests/unit/UserBackendTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ private function clearGuests() {
4444
$query->delete('guests_users')->execute();
4545
}
4646

47-
protected function setUp() {
47+
protected function setUp(): void {
4848
parent::setUp();
4949

5050
$this->clearGuests();
@@ -59,10 +59,10 @@ protected function setUp() {
5959
);
6060
}
6161

62-
protected function tearDown() {
62+
protected function tearDown(): void {
6363
$this->clearGuests();
6464

65-
return parent::tearDown();
65+
parent::tearDown();
6666
}
6767

6868
public function testCreate() {

0 commit comments

Comments
 (0)