Fix some issues

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Author: CarlSchwan

.github/workflows/lint-stylelint.yml

@@ -5,6 +5,7 @@ The format is mostly based on [Keep a Changelog](https://keepachangelog.com/en/1
 # Unreleased
 ## [18.x.x]
 ### Changed
+- Ported the admin settings to vue (#2353)
 
 ### Fixed
 - Fix PHP 8.1 deprecations (#1861)

CHANGELOG.md

@@ -48,7 +48,7 @@ public function isCronProperlyConfigured(): bool
         $cronOff = !boolval($this->settings->getAppValue(
             Application::NAME,
             'useCronUpdates',
-            Application::DEFAULT_SETTINGS['useCronUpdates']
+            (string)Application::DEFAULT_SETTINGS['useCronUpdates']
         ));
 
         // check for cron modes which may lead to problems

lib/Service/StatusService.php

@@ -30,8 +30,8 @@ public function getForm()
             $this->initialState->provideInitialState($setting, $this->config->getAppValue(
                 Application::NAME,
                 $setting,
-                Application::DEFAULT_SETTINGS[$setting])
-            );
+                (string)Application::DEFAULT_SETTINGS[$setting]
+            ));
         }
 
         return new TemplateResponse(Application::NAME, 'admin', []);

lib/Settings/AdminSettings.php

@@ -87,8 +87,8 @@ export default {
 				appId: 'news',
 				key,
 			})
-			if (value === true || value === false) {
-				value = value ? '0' : '1'
+			if (key === 'useCronUpdates') {
+				value = value ? '1' : '0'
 			}
 			try {
 				const { data } = await axios.post(url, {
@@ -99,7 +99,7 @@ export default {
 				})
 			} catch (e) {
 				this.handleResponse({
-					errorMessage: t('news', 'Unable to update share by mail config'),
+					errorMessage: t('news', 'Unable to update news config'),
 					error: e,
 				})
 			}
@@ -122,7 +122,7 @@ export default {
 		margin-bottom: 1rem;
 	}
 
-	input {
+	.input-field {
 		max-width: 350px;
 	}
 }

src/components/AdminSettings.vue

@@ -60,7 +60,7 @@ public function testGetStatus()
             ->will($this->returnValueMap([
                 ['news', 'installed_version', '', '1.0'],
                 ['core', 'backgroundjobs_mode', '', 'cron'],
-                ['news', 'useCronUpdates', true, true],
+                ['news', 'useCronUpdates', (string)true, (string)true],
             ]));
 
         $this->connection->expects($this->exactly(1))