Skip to content

Conversation

@raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Aug 9, 2022

This fixes (and simplifies) the styling of the Actions component in the Breadcrumbs component, which is broken due to #2911. To allow to re-use the ButtonVue styling, I allowed to forward the type prop from the Actions to the ButtonVue component.

Closes #2988.

Before:
Screenshot 2022-08-09 at 23-06-16 Nextcloud Vue Style Guide

After:
Screenshot 2022-08-09 at 23-10-35 Nextcloud Vue Style Guide

@raimund-schluessler raimund-schluessler added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components regression Regression of a previous working feature feature: breadcrumbs Related to the breadcrumbs components labels Aug 9, 2022
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 9, 2022
@raimund-schluessler raimund-schluessler force-pushed the fix/2988/breadcrumbs-actions branch from 0ef453f to 476018a Compare August 9, 2022 21:11
@raimund-schluessler raimund-schluessler merged commit 8babc2c into master Aug 10, 2022
@raimund-schluessler raimund-schluessler deleted the fix/2988/breadcrumbs-actions branch August 10, 2022 09:04
@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components feature: breadcrumbs Related to the breadcrumbs components regression Regression of a previous working feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Actions in Breadcrumbs not styled correctly

4 participants