Skip to content

Import tooltip directive only locally #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Aug 10, 2022
Merged

Import tooltip directive only locally #2998

PVince81 merged 1 commit into from
Aug 10, 2022

Conversation

@raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Aug 10, 2022 •
edited
Loading

This changes the RichContenteditable component to locally import the tooltip directive. Hence, a global import by the app developer is not necessary anymore.

@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 10, 2022
@raimund-schluessler raimund-schluessler added enhancement New feature or request feature: tooltip Related to the tooltip directive labels Aug 10, 2022
@raimund-schluessler raimund-schluessler marked this pull request as ready for review August 10, 2022 15:29
@raimund-schluessler raimund-schluessler added the 3. to review Waiting for reviews label Aug 10, 2022
@raimund-schluessler raimund-schluessler marked this pull request as draft August 10, 2022 19:04
@raimund-schluessler raimund-schluessler marked this pull request as ready for review August 10, 2022 19:08
PVince81
PVince81 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit e76f2bc into master Aug 10, 2022
@PVince81 PVince81 deleted the fix/noid/import-tooltip branch August 10, 2022 19:57
@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@GretaD GretaD Awaiting requested review from GretaD

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

2 more reviewers

@PVince81 PVince81 PVince81 approved these changes

@vinicius73 vinicius73 vinicius73 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request feature: tooltip Related to the tooltip directive

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@raimund-schluessler @PVince81 @vinicius73