Skip to content

Allow querying for resources with complex item ids #3404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 1 commit into from
Nov 2, 2022
Merged

Allow querying for resources with complex item ids #3404

Pytal merged 1 commit into from
Nov 2, 2022

Conversation

@Pytal
Copy link
Contributor

@Pytal Pytal commented Oct 29, 2022

Query for resources with the item id as a query string parameter instead of a URL path segment to allow for complex ids

For nextcloud/related_resources#124

@Pytal Pytal added enhancement New feature or request 3. to review Waiting for reviews labels Oct 29, 2022
@Pytal Pytal added this to the 7.1.0 milestone Oct 29, 2022
@Pytal Pytal self-assigned this Oct 29, 2022
PVince81
PVince81 approved these changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 hope it won't break backward compat though

@Pytal
Copy link
Contributor Author

Pytal commented Oct 31, 2022

👍 hope it won't break backward compat though

related_resources v1 major for stable25 will keep the /related/{providerId}/{itemId} route, it is only dropped for NC26

@Pytal Pytal requested a review from artonge October 31, 2022 18:26
@Pytal
Copy link
Contributor Author

Pytal commented Nov 2, 2022

/rebase

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2022
@Pytal Pytal merged commit 12ca6dc into master Nov 2, 2022
@Pytal Pytal deleted the enh/fetch-resources branch November 2, 2022 23:24
@skjnldsv skjnldsv mentioned this pull request Nov 15, 2022
Merged
@nickvergessen
Copy link
Contributor

nickvergessen commented Nov 17, 2022

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

+1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal @nickvergessen @PVince81 @artonge