Fix password_policy fallback handling #3408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
2 tasks
danxuliu
approved these changes
Oct 31, 2022
Contributor
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Not tested, but code looks good.
Should the handling of null and undefined be unified?
skjnldsv
approved these changes
Nov 1, 2022
skjnldsv
reviewed
Nov 1, 2022
The defined fallback is only affecting when no core=>capabilities is there. But that is pretty unlikely, while the password_policy entry can be missing easily. Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/fix-password-policy-fallback-handling
branch
from
0204f6d to
d8fc2a8
Compare
Contributor
Author
With the current approach they are. |
skjnldsv
added
4. to release
skjnldsv
deleted the
bugfix/noid/fix-password-policy-fallback-handling
branch
Merged
Contributor
Author
|
|
Contributor
Author
|
/backport to stable7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defined fallback is only affecting when no core=>capabilities is there. But that is pretty unlikely while the password_policy entry can be missing often (app not installed, unit tests, ...)
Also null vs. undefined gives different results:
https://github.com/nextcloud/nextcloud-vue/blob/0204f6dd86ad16e9b57d8c5915ee15672d4a5e5a/src/components/NcPasswordField/NcPasswordField.vue#L354-L359
Fixes the failing JS unit test in: nextcloud/spreed#8213