fix the size of the popper element

[szaimen]

Fix nextcloud/server#33839

Before	After

Signed-off-by: Simon L [email protected]

[szaimen]

/backport to stable7

[skjnldsv]

Is there no way for the popper element to automatically detect out-of-bound window ?

Also, if you add 10 links and open the last menu, isn't the issue going to be the same?

[szaimen]

Is there no way for the popper element to automatically detect out-of-bound window ?

Honestly, I don't know.

Also, if you add 10 links and open the last menu, isn't the issue going to be the same?

I can test this case but I think it should work correctly.

[szaimen]

Also, if you add 10 links and open the last menu, isn't the issue going to be the same?

I can test this case but I think it should work correctly.

@skjnldsv shall I test it?

[juliusknorr]

I think the 50vh approach might also not work well if the header is larger (e.g. with a preview). Maybe we can change the popper positioning strategy so that the popover is not limited to the tab area but may also span over the full window height and be positioned to the left of the button?

[juliusknorr]

Is there no way for the popper element to automatically detect out-of-bound window ?

Might not work in a generic way, so maybe that is something that needs rather some fine tuning in the sharing sidebar implementation.

[szaimen]

I think the 50vh approach might also not work well if the header is larger (e.g. with a preview)

No, that is no problem as it will overlap the preview header then. Let me test this out as well...

[szaimen]

@skjnldsv @juliushaertl both edge cases seem to work:

[szaimen]

@skjnldsv @juliushaertl can you approve? :)

[szaimen]

One additional review needed :)

[PVince81]

👍 nice

[nickvergessen]

/backport to stable7

[backportbot-nextcloud]

The backport to stable7 failed. Please do this backport manually.

[szaimen]

/backport to stable7

[backportbot-nextcloud]

The backport to stable7 failed. Please do this backport manually.