Define global focus trap #3478
Merged
Define global focus trap #3478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
skjnldsv
requested review from
a team,
juliusknorr,
raimund-schluessler and
vinicius73
skjnldsv
requested review from
Pytal,
artonge and
szaimen
and removed request for
a team
skjnldsv
force-pushed
the
fix/focus-trap
branch
from
5d9d576 to
dfe69f7
Compare
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
fix/focus-trap
branch
from
dfe69f7 to
0af56e8
Compare
artonge
reviewed
Nov 15, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
juliusknorr
approved these changes
Nov 15, 2022
Contributor
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Tested and works with text/viewer
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focus-trap/focus-trap#826