Don't overwrite router-link href in NcBreadcrumb

[raimund-schluessler]

We currently wrongfully overwrite the href attribute of the router-link in NcBreadcrumb with the default href prop value. This makes the link rendered by router-link to not have its href attribute correctly set, which prevents the default link behavior. Navigating still works though, so I guess this is why we didn't notice yet. This PR fixes it by only setting the href attribute from the prop if it's not a router-link.

[ShGKme]

Instead of fixing it in the NcBreadcrumb, shouldn't we fix it in NvBreadcrumbs, where wrong props are passed?

https://github.com/nextcloud/nextcloud-vue/blob/f46bba55b191d25497878c41e00c1feb42ab36d4/src/components/NcBreadcrumbs/NcBreadcrumbs.vue#L552-L572

[raimund-schluessler]

Instead of fixing it in the NcBreadcrumb, shouldn't we fix it in NvBreadcrumbs, where wrong props are passed?

https://github.com/nextcloud/nextcloud-vue/blob/f46bba55b191d25497878c41e00c1feb42ab36d4/src/components/NcBreadcrumbs/NcBreadcrumbs.vue#L552-L572

The lines you show here are not related to the problem. They are for showing the hidden crumbs in a dropdown menu. NcBreadcrumb is used explicitly by the dev and hence definitely needs a fix. We can of course, as a follow-up, also adjust these lines to not pass href to NcActionRouter, but NcActionRouter does not care if its provided an undefined href, so I am not sure it's worth the effort.

[ShGKme]

The lines you show here are not related to the problem. They are for showing the hidden crumbs in a dropdown menu.

Yep, sorry, didn't look carefully